Skip to content

Commit

Permalink
Add skylight; create distinct debug, lint, demo, production Gemfile g…
Browse files Browse the repository at this point in the history 
…roups (#1069)
  • Loading branch information
@bensheldon
bensheldon authored Sep 11, 2023
1 parent c0e1408 commit 36d6973
Show file tree
Hide file tree
Showing 26 changed files with 300 additions and 159 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
BUNDLE_JOBS: 4
BUNDLE_RETRY: 3
BUNDLE_PATH: vendor/bundle
BUNDLE_WITHOUT: lint
BUNDLE_WITHOUT: debug:lint:demo:production
RAILS_LOG_TO_STDOUT: false
services:
postgres:
Expand Down
20 changes: 13 additions & 7 deletions Gemfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,29 @@ gemspec
# your gem to rubygems.org.

gem 'activerecord-jdbcpostgresql-adapter', platforms: [:jruby]
gem 'appraisal', github: 'thoughtbot/appraisal', branch: 'main'
gem 'appraisal'
gem 'matrix'
gem 'nokogiri'
gem 'pg', platforms: [:mri, :mingw, :x64_mingw]
gem 'rack', '~> 2.2'
gem 'rails'

platforms :ruby do
gem "activerecord-explain-analyze", require: false
gem "dotenv"
gem "foreman"
gem "gem-release"
gem "github_changelog_generator", require: false
gem "net-imap", require: false
gem "net-pop", require: false
gem "net-smtp", require: false
gem "pry-byebug"
gem "rack-mini-profiler"
gem "rbtrace"

gem "stackprof"
gem "tapioca", require: false, group: :development
group :debug do
gem "activerecord-explain-analyze", require: false
gem "pry-byebug"
gem "rack-mini-profiler"
gem "rbtrace"
gem "stackprof"
end

group :lint do
gem "easy_translate"
Expand All @@ -49,5 +50,10 @@ platforms :ruby do
gem "sorbet"
gem "sorbet-runtime"
gem "spoom", require: false
gem "tapioca", require: false
end

group :demo, :production do
gem "skylight"
end
end
167 changes: 78 additions & 89 deletions Gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,3 @@
GIT
remote: https://github.com/thoughtbot/appraisal.git
revision: feb78bcc6177038399bff098cb6c2bd4bca4972a
branch: main
specs:
appraisal (2.5.0)
bundler
rake
thor (>= 0.14.0)

PATH
remote: .
specs:
Expand All @@ -22,59 +12,59 @@ PATH
GEM
remote: https://rubygems.org/
specs:
actioncable (7.0.7.2)
actionpack (= 7.0.7.2)
activesupport (= 7.0.7.2)
actioncable (7.0.8)
actionpack (= 7.0.8)
activesupport (= 7.0.8)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
actionmailbox (7.0.7.2)
actionpack (= 7.0.7.2)
activejob (= 7.0.7.2)
activerecord (= 7.0.7.2)
activestorage (= 7.0.7.2)
activesupport (= 7.0.7.2)
actionmailbox (7.0.8)
actionpack (= 7.0.8)
activejob (= 7.0.8)
activerecord (= 7.0.8)
activestorage (= 7.0.8)
activesupport (= 7.0.8)
mail (>= 2.7.1)
net-imap
net-pop
net-smtp
actionmailer (7.0.7.2)
actionpack (= 7.0.7.2)
actionview (= 7.0.7.2)
activejob (= 7.0.7.2)
activesupport (= 7.0.7.2)
actionmailer (7.0.8)
actionpack (= 7.0.8)
actionview (= 7.0.8)
activejob (= 7.0.8)
activesupport (= 7.0.8)
mail (~> 2.5, >= 2.5.4)
net-imap
net-pop
net-smtp
rails-dom-testing (~> 2.0)
actionpack (7.0.7.2)
actionview (= 7.0.7.2)
activesupport (= 7.0.7.2)
actionpack (7.0.8)
actionview (= 7.0.8)
activesupport (= 7.0.8)
rack (~> 2.0, >= 2.2.4)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.0)
rails-html-sanitizer (~> 1.0, >= 1.2.0)
actiontext (7.0.7.2)
actionpack (= 7.0.7.2)
activerecord (= 7.0.7.2)
activestorage (= 7.0.7.2)
activesupport (= 7.0.7.2)
actiontext (7.0.8)
actionpack (= 7.0.8)
activerecord (= 7.0.8)
activestorage (= 7.0.8)
activesupport (= 7.0.8)
globalid (>= 0.6.0)
nokogiri (>= 1.8.5)
actionview (7.0.7.2)
activesupport (= 7.0.7.2)
actionview (7.0.8)
activesupport (= 7.0.8)
builder (~> 3.1)
erubi (~> 1.4)
rails-dom-testing (~> 2.0)
rails-html-sanitizer (~> 1.1, >= 1.2.0)
activejob (7.0.7.2)
activesupport (= 7.0.7.2)
activejob (7.0.8)
activesupport (= 7.0.8)
globalid (>= 0.3.6)
activemodel (7.0.7.2)
activesupport (= 7.0.7.2)
activerecord (7.0.7.2)
activemodel (= 7.0.7.2)
activesupport (= 7.0.7.2)
activemodel (7.0.8)
activesupport (= 7.0.8)
activerecord (7.0.8)
activemodel (= 7.0.8)
activesupport (= 7.0.8)
activerecord-explain-analyze (0.1.0)
activerecord (>= 4)
pg
Expand All @@ -83,20 +73,24 @@ GEM
activerecord-jdbcpostgresql-adapter (70.1-java)
activerecord-jdbc-adapter (= 70.1)
jdbc-postgres (>= 9.4, < 43)
activestorage (7.0.7.2)
actionpack (= 7.0.7.2)
activejob (= 7.0.7.2)
activerecord (= 7.0.7.2)
activesupport (= 7.0.7.2)
activestorage (7.0.8)
actionpack (= 7.0.8)
activejob (= 7.0.8)
activerecord (= 7.0.8)
activesupport (= 7.0.8)
marcel (~> 1.0)
mini_mime (>= 1.1.0)
activesupport (7.0.7.2)
activesupport (7.0.8)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
addressable (2.8.5)
public_suffix (>= 2.0.2, < 6.0)
appraisal (2.5.0)
bundler
rake
thor (>= 0.14.0)
ast (2.4.2)
async (2.6.4)
console (~> 1.10)
Expand All @@ -114,7 +108,7 @@ GEM
async-http-faraday (0.12.0)
async-http (~> 0.42)
faraday
async-io (1.35.0)
async-io (1.36.0)
async
async-pool (0.4.0)
async (>= 1.25)
Expand Down Expand Up @@ -187,7 +181,7 @@ GEM
octokit (~> 4.6)
rainbow (>= 2.2.1)
rake (>= 10.0)
globalid (1.2.0)
globalid (1.2.1)
activesupport (>= 6.1)
highline (2.1.0)
i18n (1.14.1)
Expand Down Expand Up @@ -230,7 +224,7 @@ GEM
mixlib-shellout
method_source (1.0.0)
mini_mime (1.1.5)
minitest (5.19.0)
minitest (5.20.0)
mixlib-cli (2.1.8)
mixlib-config (3.0.27)
tomlrb
Expand Down Expand Up @@ -301,20 +295,20 @@ GEM
rack (>= 1.2.0)
rack-test (2.1.0)
rack (>= 1.3)
rails (7.0.7.2)
actioncable (= 7.0.7.2)
actionmailbox (= 7.0.7.2)
actionmailer (= 7.0.7.2)
actionpack (= 7.0.7.2)
actiontext (= 7.0.7.2)
actionview (= 7.0.7.2)
activejob (= 7.0.7.2)
activemodel (= 7.0.7.2)
activerecord (= 7.0.7.2)
activestorage (= 7.0.7.2)
activesupport (= 7.0.7.2)
rails (7.0.8)
actioncable (= 7.0.8)
actionmailbox (= 7.0.8)
actionmailer (= 7.0.8)
actionpack (= 7.0.8)
actiontext (= 7.0.8)
actionview (= 7.0.8)
activejob (= 7.0.8)
activemodel (= 7.0.8)
activerecord (= 7.0.8)
activestorage (= 7.0.8)
activesupport (= 7.0.8)
bundler (>= 1.15.0)
railties (= 7.0.7.2)
railties (= 7.0.8)
rails-dom-testing (2.2.0)
activesupport (>= 5.0.0)
minitest
Expand All @@ -325,9 +319,9 @@ GEM
rails-i18n (7.0.8)
i18n (>= 0.7, < 2)
railties (>= 6.0.0, < 8)
railties (7.0.7.2)
actionpack (= 7.0.7.2)
activesupport (= 7.0.7.2)
railties (7.0.8)
actionpack (= 7.0.8)
activesupport (= 7.0.8)
method_source
rake (>= 12.2)
thor (~> 1.0)
Expand Down Expand Up @@ -362,7 +356,7 @@ GEM
rspec-mocks (~> 3.12)
rspec-support (~> 3.12)
rspec-support (3.12.1)
rubocop (1.56.2)
rubocop (1.56.3)
base64 (~> 0.1.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
Expand All @@ -383,11 +377,11 @@ GEM
rubocop-performance (1.19.0)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rails (2.20.2)
rubocop-rails (2.21.0)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.33.0, < 2.0)
rubocop-rspec (2.23.2)
rubocop-rspec (2.24.0)
rubocop (~> 1.33)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
Expand All @@ -401,25 +395,18 @@ GEM
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
skylight (5.3.4)
activesupport (>= 5.2.0)
smart_properties (1.17.0)
sorbet (0.5.11001)
sorbet-static (= 0.5.11001)
sorbet-runtime (0.5.11001)
sorbet-static (0.5.11001-java)
sorbet-static (0.5.11001-universal-darwin-14)
sorbet-static (0.5.11001-universal-darwin-15)
sorbet-static (0.5.11001-universal-darwin-16)
sorbet-static (0.5.11001-universal-darwin-17)
sorbet-static (0.5.11001-universal-darwin-18)
sorbet-static (0.5.11001-universal-darwin-19)
sorbet-static (0.5.11001-universal-darwin-20)
sorbet-static (0.5.11001-universal-darwin-21)
sorbet-static (0.5.11001-universal-darwin-22)
sorbet-static (0.5.11001-universal-darwin-23)
sorbet-static (0.5.11001-x86_64-linux)
sorbet-static-and-runtime (0.5.11001)
sorbet (= 0.5.11001)
sorbet-runtime (= 0.5.11001)
sorbet (0.5.11011)
sorbet-static (= 0.5.11011)
sorbet-runtime (0.5.11011)
sorbet-static (0.5.11011-java)
sorbet-static (0.5.11011-universal-darwin)
sorbet-static (0.5.11011-x86_64-linux)
sorbet-static-and-runtime (0.5.11011)
sorbet (= 0.5.11011)
sorbet-runtime (= 0.5.11011)
spoom (1.2.3)
erubi (>= 1.10.0)
sorbet-static-and-runtime (>= 0.5.10187)
Expand Down Expand Up @@ -473,6 +460,7 @@ GEM

PLATFORMS
arm64-darwin
arm64-darwin-22
java
universal-java-11
universal-java-17
Expand All @@ -482,7 +470,7 @@ PLATFORMS
DEPENDENCIES
activerecord-explain-analyze
activerecord-jdbcpostgresql-adapter
appraisal!
appraisal
benchmark-ips
capybara
dotenv
Expand Down Expand Up @@ -515,6 +503,7 @@ DEPENDENCIES
rubocop-rails
rubocop-rspec
selenium-webdriver
skylight
sorbet
sorbet-runtime
spoom
Expand All @@ -524,4 +513,4 @@ DEPENDENCIES
yard-activesupport-concern

BUNDLED WITH
2.4.14
2.4.19
2 changes: 1 addition & 1 deletion app/filters/good_job/batches_filter.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def filtered_query(_filtered_params = params)
end

def default_base_query
GoodJob::BatchRecord.all.includes(:jobs)
GoodJob::BatchRecord.includes(:jobs)
end
end
end
Loading

0 comments on commit 36d6973

Please sign in to comment.