Use ActiveSupport::BroadcastLogger (#1089)

.gitignore

@@ -1,5 +1,5 @@
 .bundle/
-log/*.log
+log/
 pkg/
 vendor/bundle
 spec/test_app/log/*.log

lib/good_job/log_subscriber.rb

@@ -208,13 +208,15 @@ def loggers
       # each of the loggers in {LogSubscriber.loggers}.
       # @return [Logger]
       def logger
-        @_logger ||= begin
-          logger = Logger.new(StringIO.new)
-          loggers.each do |each_logger|
-            logger.extend(ActiveSupport::Logger.broadcast(each_logger))
-          end
-          logger
-        end
+        @_logger ||= if defined?(ActiveSupport::BroadcastLogger)
+                       ActiveSupport::BroadcastLogger.new(*loggers)
+                     else
+                       logger = Logger.new(StringIO.new)
+                       loggers.each do |each_logger|
+                         logger.extend(ActiveSupport::Logger.broadcast(each_logger))
+                       end
+                       logger
+                     end
       end
 
       # Reset {LogSubscriber.logger} and force it to rebuild a new shortcut to

sorbet/rbi/todo.rbi

@@ -17,8 +17,6 @@ module ::LATCH; end
 module ::MemoryProfiler; end
 module ::PERFORMED; end
 module ::POLL_COUNT; end
-module ::RECEIVED_MESSAGE; end
-module ::REFRESH_IF_STALE_CALLED; end
 module ::RESULTS; end
 module ::RUN_JOBS; end
 module ::RecursiveJob; end
@@ -29,6 +27,7 @@ module ::THREAD_JOBS; end
 module ::TestError; end
 module ::TestJob; end
 module ::TestJob::ExpectedError; end
+module ActiveSupport::BroadcastLogger; end
 module GoodJob::Job::ERROR_EVENT_INTERRUPTED; end
 module GoodJob::Job::ERROR_EVENT_RETRIED; end
 module RSpec::Core::Example; end

spec/support/database_cleaner.rb

@@ -6,7 +6,7 @@
   config.use_transactional_fixtures = false
 
   config.before(:suite) do
-    ApplicationRecord.clear_active_connections!
+    ApplicationRecord.connection_handler.clear_active_connections!
     ApplicationRecord.connection_pool.disconnect
     ApplicationRecord.connection_pool.with_connection do |connection|
       connection.truncate_tables(*connection.tables)
@@ -16,7 +16,7 @@
   config.around do |example|
     example.run
 
-    ApplicationRecord.clear_active_connections!
+    ApplicationRecord.connection_handler.clear_active_connections!
     ApplicationRecord.connection_pool.disconnect
     ApplicationRecord.connection_pool.with_connection do |connection|
       connection.truncate_tables(*connection.tables)