Skip to content

Commit

Permalink
Remove deprecation silencers for v3.99 release
Browse files Browse the repository at this point in the history
  • Loading branch information
bensheldon committed Jul 6, 2024
1 parent 3baddb1 commit b7d6006
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions app/models/good_job/base_execution.rb
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,10 @@ def self.build_for_enqueue(active_job, overrides = {})

# Construct arguments for GoodJob::Execution from an ActiveJob instance.
def self.enqueue_args(active_job, overrides = {})
if active_job.priority && GoodJob.configuration.smaller_number_is_higher_priority.nil?
if active_job.priority && GoodJob.configuration.smaller_number_is_higher_priority == false
GoodJob.deprecator.warn(<<~DEPRECATION)
The next major version of GoodJob (v4.0) will change job `priority` to give smaller numbers higher priority (default: `0`), in accordance with Active Job's definition of priority.
To opt-in to this behavior now, set `config.good_job.smaller_number_is_higher_priority = true` in your GoodJob initializer or application.rb.
To not opt-in yet, but silence this deprecation warning, set `config.good_job.smaller_number_is_higher_priority = false`.
DEPRECATION
end

Expand Down

0 comments on commit b7d6006

Please sign in to comment.