Show basename of proctitle (#679)

* Show basename of proctitle

* Show full proctitle in title attribute

* Fix lint error in spec

app/views/good_job/processes/index.html.erb

@@ -25,10 +25,10 @@
       <div id="<%= dom_id(process) %>" class="<%= dom_class(process) %> list-group-item py-3" role="row">
         <div class="row align-items-center">
           <div class="col">
-            <code class="font-monospace">
+            <%= tag.code title: process.state['proctitle'], class: "font-monospace" do %>
               <span class="text-muted opacity-50">$</span>
-              <%= process.state["proctitle"] %>
-            </code>
+              <%= process.basename %>
+            <% end %>
             <div>
               <span class="text-muted small">PID</span>
               <span class="badge rounded-pill bg-light text-dark"><%= process.state["pid"] %></span>

lib/models/good_job/process.rb

@@ -71,5 +71,9 @@ def deregister
       destroy!
       advisory_unlock
     end
+
+    def basename
+      File.basename(state["proctitle"])
+    end
   end
 end

spec/lib/models/good_job/process_spec.rb

@@ -46,4 +46,18 @@
       expect { process.deregister }.to change(described_class, :count).by(-1)
     end
   end
+
+  describe '#basename' do
+    let(:process) { described_class.new state: {} }
+
+    it 'splits proctitle on dir and program name' do
+      process.state['proctitle'] = '/app/bin/good_job'
+      expect(process.basename).to eq('good_job')
+    end
+
+    it 'preserves program arguments' do
+      process.state['proctitle'] = '/Users/me/projects/good_job/bin/bundle exec rails start'
+      expect(process.basename).to eq('bundle exec rails start')
+    end
+  end
 end