Fix GoodJob.cleanup_preserved_jobs to add missing guard for unmigra…

…ted discrete executions (#938)
bensheldon · Apr 24, 2023 · f6e5c24 · f6e5c24
1 parent bf112c2
commit f6e5c24
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/good_job.rb b/lib/good_job.rb
@@ -178,8 +178,10 @@ def self.cleanup_preserved_jobs(older_than: nil, in_batches_of: 1_000)
         active_job_ids = jobs_query.pluck(:active_job_id)
         break if active_job_ids.empty?
 
-        deleted_discrete_executions = GoodJob::DiscreteExecution.where(active_job_id: active_job_ids).delete_all
-        deleted_discrete_executions_count += deleted_discrete_executions
+        if GoodJob::Execution.discrete_support?
+          deleted_discrete_executions = GoodJob::DiscreteExecution.where(active_job_id: active_job_ids).delete_all
+          deleted_discrete_executions_count += deleted_discrete_executions
+        end
 
         deleted_executions = GoodJob::Execution.where(active_job_id: active_job_ids).delete_all
         deleted_executions_count += deleted_executions