Add GoodJob.configure_active_record as alternative to GoodJob.active_record_parent_class
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve_record_parent_class`
bensheldon
force-pushed
the
deprecate-active_record_parent_class
branch
from
cdd01bb to
5e09081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to introduce an alternative to
GoodJob.active_record_parent_classthat was slightly more supported than asking the developer to include the behavior in their ownto_prepareinitializer.I was initially going to deprecate it in this PR, but figured I'd offer them both for now as I think Sorbet tolerates the current logic.
Connects to #1000