Allow Probe Server's /connect
to handle a certain number of reconnects before statusing
#1075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1068.
Once GoodJob has successfully connected, Probe Server's
/connected
endpoint will continue returning 200-success if the database connection is lost and reconnections are attempted. This is now aligned with the existing thread-error reporting behavior:good_job/lib/good_job/notifier.rb
Lines 152 to 160 in 3c45787
I also increased the number of reconnect attempts, so it will now be 6 attempts, once every 5 seconds = 30 seconds of reconnecting before the
Notifier#connected?
will become false and the Probe Server will start returning a 503 and theGoodJob.on_thread_error
callback will be triggered.Also some slight refactoring so that the utility methods
listen?
andwait?
are now condition variables and have a timeout.