v5: Update compatibility matrix, remove compatibility code #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
update-compatibility-matrix
branch
from
0cbaed5 to
cea8018
Compare
|
Ugh 🤦🏻 Yes, I agree we should defer this to GoodJob v5 because it would have breakage. |
bensheldon
changed the title
|
I noted this in #1407 |
|
@Earlopain Could you send me an email at [email protected] or tell me a good way to get in touch? I wanted to talk to you about maintainership 🙇🏻 |
|
Sure, I can get in touch in a bit when I got more time. I will pick changes from here that wre good to go now then as well |
|
Just wondering if you got my mail? I should have written you on the same day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4 updated what it is compatible with but docs weren't updated. I've based these versions on what is written in the v4 upgrade guide.
Honestly not sure if this is possible to do now. While v4 was supposed to drop older postgres versions, I don't think this is enforced anywhere right now and probably still works with at least postgres 11. The rails and ruby constraint at least is enforced through the gemspec.
v4 has been out for about a month now. I would defer the postgres changes for the next major myself, unless there is a check somewhere I didn't find? Let me know what you think.