Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better search job arguments (including integers) by adding serialized_params->>arguments explicitly #1504

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

bensheldon
Copy link
Owner

Fixes #1458

@bensheldon bensheldon added the bug Something isn't working label Oct 10, 2024
@bensheldon bensheldon merged commit ce2dbd9 into main Oct 10, 2024
10 checks passed
@bensheldon bensheldon deleted the search-job-args branch October 10, 2024 13:12
Copy link

@swaathi swaathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think test coverage can be improved to include this update?

it 'searches serialized params' do
expect(model_class.search_text('example_value')).to include(job)
end

This tests only string arguments.

@bensheldon
Copy link
Owner Author

@swaathi yes, that would be the right thing to do 😉 I'll push a quick test for this.

@bensheldon
Copy link
Owner Author

@swaathi fyi: #1510

@swaathi
Copy link

swaathi commented Oct 11, 2024

Awesome! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Searching for an integer type argument (on the dashboard) does not yeild any results
2 participants