Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded include of pg_locks in query when displaying jobs table #1541

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Remove unneeded include of pg_locks in query when displaying jobs table #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/filters/good_job/jobs_filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def filtered_query(filter_params = params)
when 'scheduled'
query = query.scheduled
when 'running'
query = query.running.select("#{GoodJob::Job.table_name}.*", 'pg_locks.locktype')
query = query.running
when 'queued'
query = query.queued
end
Expand All @@ -55,7 +55,7 @@ def filtered_count
private

def query_for_records
filtered_query.includes_advisory_locks
filtered_query
end

def default_base_query
Expand Down