Added metrics to Scheduler and track in Process state

lib/good_job/metrics.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+module GoodJob # :nodoc:
+  class Metrics
+    attr_reader :failed_count, :succeeded_count
+
+    def initialize
+      @failed_count = 0
+      @succeeded_count = 0
+    end
+
+    def increment_failed
+      @failed_count += 1
+    end
+
+    def increment_succeeded
+      @succeeded_count += 1
+    end
+  end
+end

lib/good_job/scheduler.rb

@@ -3,6 +3,7 @@
 require "concurrent/executor/timer_set"
 require "concurrent/scheduled_task"
 require "concurrent/utility/processor_counter"
+require 'good_job/metrics'
 
 module GoodJob # :nodoc:
   #
@@ -88,6 +89,7 @@ def initialize(performer, max_threads: nil, max_cache: nil, warm_cache_on_initia
       @executor_options[:name] = name
 
       @cleanup_tracker = CleanupTracker.new(cleanup_interval_seconds: cleanup_interval_seconds, cleanup_interval_jobs: cleanup_interval_jobs)
+      @metrics = ::GoodJob::Metrics.new
       create_executor
       warm_cache if warm_cache_on_initialize
     end
@@ -203,6 +205,12 @@ def task_observer(time, output, thread_error)
       instrument("finished_job_task", { result: output, error: thread_error, time: time })
       return unless output
 
+      if error
+        @metrics.increment_failed
+      else
+        @metrics.increment_succeeded
+      end
+
       @cleanup_tracker.increment
       if @cleanup_tracker.cleanup?
         cleanup
@@ -222,6 +230,9 @@ def stats
         max_cache: @max_cache,
         active_cache: cache_count,
         available_cache: remaining_cache_count,
+        succeeded_count: @metrics.succeeded_count,
+        failed_count: @metrics.failed_count,
+        total_count: @metrics.succeeded_count + @metrics.failed_count,
       }
     end
 

spec/lib/good_job/scheduler_spec.rb

@@ -62,6 +62,25 @@
 
         expect(error_proc).to have_received(:call).with(an_instance_of(StandardError).and(having_attributes(message: 'oopsy'))).at_least(:once)
       end
+
+      it 'increases failed job count' do
+        expect(performer).to receive(:next) do
+          THREAD_HAS_RUN.make_true
+          GoodJob::ExecutionResult.new(value: nil, unhandled_error: StandardError.new("oopsy"))
+        end
+
+        allow(error_proc).to receive(:call) do
+          ERROR_TRIGGERED.make_true
+        end
+
+        scheduler = described_class.new(performer)
+        scheduler.create_thread
+        sleep_until { THREAD_HAS_RUN.true? }
+        sleep_until { ERROR_TRIGGERED.true? }
+
+        expect(scheduler.stats.fetch(:failed_count)).to eq 1
+        expect(scheduler.stats.fetch(:succeeded_count)).to eq 0
+      end
     end
   end
 
@@ -177,6 +196,9 @@
                                       max_cache: max_cache,
                                       active_cache: 0,
                                       available_cache: max_cache,
+                                      failed_count: 0,
+                                      succeeded_count: 0,
+                                      total_count: 0,
                                     })
     end
   end