Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update HPA api to v2 for K8s 1.24+ #113

Closed
wants to merge 2 commits into from

Conversation

davidspek
Copy link
Contributor

Fixes: bentoml/Yatai#449

This PR updates the HPA version used by the backend from v2beta2 to v2 to support newer versions of Kubernetes. Note: this does mean that Kubernetes v1.23.0 will be the new minimum supported version. Since Kubernetes v1.27.0 was recently released I believe this shouldn't be a large problem.

Related to: bentoml/Yatai#463

Signed-off-by: David van der Spek <[email protected]>
@yetone
Copy link
Member

yetone commented May 5, 2023

Thank you for your contribution! We want to be forward compatible because our commitment is to support v1.20+ and we need to make sure that users of v1.20 ~ v1.23 versions of k8s can continue to use yatai-deployment

@FogDong
Copy link
Member

FogDong commented May 8, 2023

Hi @davidspek , thanks for the contribution!

As yetone said, we'd like to ensure the compatibility so instead of the chaging the apiversion, maybe we need to use some conversion to handle the issue.
I'd like to continue to take over this issue and cherry pick your commit if you don't mind.

@davidspek
Copy link
Contributor Author

Feel free to cherry pick my commit from this PR and other ones. I haven't actually used Yatai yet but I saw this would become a problem for us and many others in the near future so wanted to get the ball rolling on a fix.

@davidspek davidspek closed this May 26, 2023
@davidspek
Copy link
Contributor Author

Closed as implemented in #114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoscaling/v2beta2 is deprecated in k8s 1.23
3 participants