Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend supported Firebase Authentication #47

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LaszloDev
Copy link
Collaborator

@LaszloDev LaszloDev commented Sep 9, 2019

This is a concept for extending and providing support for multiple Firebase authentication modes.

Default will still be firebase.auth.signInWithEmailAndPassword(), but this PR opens the possibility to write your own LoginPage-component which can pass a mode to the React-Admin LOGIN-action. Based on this mode different Firebase authentications will be possible.

In the first stepp I implement the mode link, which refers to Firebase "Email Link" authentication method. (Find out more here https://firebase.google.com/docs/auth/web/email-link-auth)

Open tasks / Bugs:

  • Auth method "link": Provide option to configure actionCodeSettings-object
  • Auth method "link": Display different text on the "login"-button based on link request or actual login
  • Auth method "link": Show notification when success requested an email login
  • Auth method "link": Prevent reload when requesting the login email
  • Implement more authentication methods

Related Issues:

Let me know if you see issues or alternative ways to implement this extension.

@LaszloDev LaszloDev mentioned this pull request Sep 11, 2019
@benwinding
Copy link
Owner

Hey @LaszloDev,

Looks like a great start, I like the way you've implemented the mode option to determine the auth strategy to use in the app. The only thing I would only suggest looking at this project:

https://github.com/firebase/firebaseui-web

It's a popular way to implement different authentication methods with the Firebase sdk and might make things a bit easier (but I'm not sure). Thanks again.

Cheers,
Ben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants