-
Notifications
You must be signed in to change notification settings - Fork 38
dev: update dependencies #30
base: master
Are you sure you want to change the base?
Conversation
commit aef39c0 Proposal to clean up the app structure and unify the configuration |
I'm finally back from traveling so I should have a chance to look at this in detail soon - thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good; thanks for the PR and especially for updating the readme!
ankdown/ankdown.py
Outdated
@@ -261,24 +259,31 @@ def __getitem__(self, deckname): | |||
def field_to_html(field): | |||
"""Need to extract the math in brackets so that it doesn't get markdowned. | |||
If math is separated with dollar sign it is converted to brackets.""" | |||
if CONFIG['dollar']: | |||
if CONFIG['math_mode'] is 'dollars': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want ==
, not is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh... coffeescript sneaks in ;-) I've pushed a fix
ankdown/ankdown.py
Outdated
|
||
|
||
return misaka.html(field, extensions=("fenced-code", "math")) | ||
if CONFIG['misaka_renderer'] is 'HighlighterRenderer': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should be ==
ankdown/ankdown.py
Outdated
# | ||
# add highlight css rules | ||
# | ||
if CONFIG['misaka_renderer'] is 'HighlighterRenderer': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should be ==
Did you notice my change commit? ;-) |
Sorry! I've been super busy again the last month or so; I'll try to merge this tonight (although my power and internet might be shut off so no promises) |
close #19