Flatten objectives #16
Conversation
docstrings optional. A good type system should do most of the work, and doc strings fill in the rest (where necessary).
plots. Also here and there stripping about excessive documentation.
Trying to see if I can do something useful with the graph plot.
There was a problem hiding this comment.
I think we should decide on ruff vs pylint now, else we also have to maintain this rule checking for both equally etc :D
I don't have a strong opinion on it, but if ruff integrates nicer in your IDE we can use that.
There was a problem hiding this comment.
I don't have a strong opinion either, but I think the main thing is making sure we only have to track one set of such things in ruff. Maybe I'd say if you'd like me to take care of it, then I'll manage the ruff/toml stuff. If you care about extra pylint features though, then it's up to you to maintain it in toml, so that I can then get the desired behaviour.
| - brain_optimizer: The BrainOptimizer instance | ||
|
|
||
| """ | ||
| def plot_brain_and_optimizers(brain: Brain, objective: Objective[ContextT]) -> Figure: |
There was a problem hiding this comment.
I think the one line comment you added to the other functions would be nice here as well as the function name is not fully explaining what to expect
There was a problem hiding this comment.
This is my strategy. I'm actually not deleting as many comments as I thought I would. I've removed the warning, but wherever a one liner of comment would be helpful I leave it/add it.
Okay I'll try and keep that in mind. You'll probably not going to like my next pull request though... |
|
If you'd prefer to have smaller merges (which I think can make sense) maybe I'd reactivate the project interface. Then basically we keep it as a big list of todos. When a checklist item gets mature enough, we turn it into an issue, and then address it with a merge. Would you prefer that strategy? Otherwise my current strategy is making thematically organized todos under issues, and addressing them in bulk. Currently I'm working on #11, which again will have a large number of changes. |
Flattened objective hierarchy so that it's no longer "Goal -> Objective -> Loss" and just "Objective -> Loss". Losses now contain a list of target circuits and weights. Overall seems to be a bit more performant because we're not doing as many loops over the AD graph. Configs updated accordingly.
Resolves #8