Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rl config #50

Merged
merged 15 commits into from
Oct 30, 2024
Merged

Fix rl config #50

merged 15 commits into from
Oct 30, 2024

Conversation

fabioseel
Copy link
Contributor

@fabioseel fabioseel commented Oct 28, 2024

Finally got the RL config working again

added a working config to the examples
made necessary changes to the rl framework + related modules to adapt to config changes

most notably I needed a function building the Brain from a DictConfig for better interfacing (and in order to not duplicate code)

@fabioseel fabioseel requested a review from alex404 October 28, 2024 13:51
@fabioseel fabioseel linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link
Contributor

@alex404 alex404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, I guess it was mostly linting outside of cleaning up the configs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you use this it all, but you can probably delete this module.

Copy link
Contributor Author

@fabioseel fabioseel Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah mostly. There were some things I wanted to look into / compare, but maybe I can add @ deprecated for now already
(rest of this will be addressed in #35 )

@fabioseel
Copy link
Contributor Author

Seems fine, I guess it was mostly linting outside of cleaning up the configs?

More or less. Actually since you changed the constructor of Brain I had to make several changes down the line, basically whereever I'm interfacing to sample factory to use the brain...
most importantly those changes can be seen in main > I factored out the block that sets up the brain into a function

also you had a check whether the config contains an optimizer which I removed. Are there cases where a config can be created without an optimizer? In any case, the config processing should be separated from the main function imho (opened a ticket for that #52)

@alex404 alex404 merged commit 8e66cb2 into master Oct 30, 2024
3 checks passed
@alex404 alex404 deleted the fix-rl-config branch October 30, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

develop example configs
2 participants