Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most ruff complaints in the project #60

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Fix most ruff complaints in the project #60

merged 7 commits into from
Oct 31, 2024

Conversation

fabioseel
Copy link
Contributor

I'm applying all the automatic fixes so that in the future our pull requests will be less cluttered with all of this and we can focus on the actual changes.

Still checking out whether I can fix some of the more advanced complaints, else we'll just have to merge it as is even though the linter might fail (as long as scan doesn't fail it should be fine)

I hope you currently don't have a branch with a lot of stuff open as this might be confusing to merge (but also might work out just fine).

@fabioseel fabioseel marked this pull request as ready for review October 31, 2024 10:58
@fabioseel fabioseel changed the title Autofixes ruff Fix most ruff complaints in the project Oct 31, 2024
@fabioseel fabioseel requested a review from alex404 October 31, 2024 10:59
@fabioseel
Copy link
Contributor Author

If you look why it fails, it's 2 deprecated functions which might be deleted soon anyway so I did not bother fixing it but added a TODO comment instead.
Still think its worth merging this decently fast in order to be able to have cleaner commits in the future :)

@fabioseel
Copy link
Contributor Author

I don't think you need to do an in depth review, most files are simply formatted etc

Copy link
Contributor

@alex404 alex404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright sure. Hopefully this doesn't conflict with the merge request I just made. I'll try to merge this into my branch.

@alex404 alex404 merged commit 19a5009 into master Oct 31, 2024
2 of 3 checks passed
@alex404 alex404 deleted the autofixes-ruff branch October 31, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants