Skip to content

Commit

Permalink
Remove unused help_text fm_step property
Browse files Browse the repository at this point in the history
It says it is unused, and it seems correct that it is unused. No traces
to be found in related repositories using this property
  • Loading branch information
berland committed Oct 9, 2024
1 parent 4cdb34e commit 45c8364
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion src/ert/config/ert_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,6 @@ def _forward_model_step_from_config_file(
required_keywords=content_dict.get("REQUIRED", []),
exec_env=exec_env,
default_mapping=default_mapping,
help_text=content_dict.get("HELP_TEXT", ""),
)
except IOError as err:
raise ConfigValidationError.with_context(str(err), config_file) from err
3 changes: 0 additions & 3 deletions src/ert/config/forward_model_step.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ class ForwardModelStep:
private_args: A dictionary of user-provided keyword arguments.
For example, if the user provides <A>=2, the dictionary will contain
{ "A": "2" }
help_text: Some meaningless old code we don't really need, not used anywhere
"""

name: str
Expand All @@ -166,7 +165,6 @@ class ForwardModelStep:
exec_env: dict[str, Union[int, str]] = field(default_factory=dict)
default_mapping: dict[str, Union[int, str]] = field(default_factory=dict)
private_args: SubstitutionList = field(default_factory=SubstitutionList)
help_text: str = ""

default_env: ClassVar[dict[str, str]] = {
"_ERT_ITERATION_NUMBER": "<ITER>",
Expand Down Expand Up @@ -254,7 +252,6 @@ def __init__(
exec_env=exec_env,
default_mapping=default_mapping,
private_args=SubstitutionList(),
help_text="",
)

@staticmethod
Expand Down
1 change: 0 additions & 1 deletion src/ert/config/parsing/forward_model_keywords.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ class ForwardModelStepKeys(StrEnum):
EXEC_ENV = "EXEC_ENV"
DEFAULT = "DEFAULT"
PRIVATE_ARGS = "PRIVATE_ARGS"
HELP_TEXT = "HELP_TEXT"
1 change: 0 additions & 1 deletion tests/ert/unit_tests/config/test_forward_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,6 @@ def validate_pre_realization_run(
},
"exec_env": {},
"default_mapping": {},
"help_text": "",
"private_args": SubstitutionList(
{
"<arg1>": "hello",
Expand Down

0 comments on commit 45c8364

Please sign in to comment.