Fix memory being reported without units in GUI

berland · Apr 25, 2024 · f1c1c47 · f1c1c47
1 parent 7d03596
commit f1c1c47
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/ert/gui/model/snapshot.py b/src/ert/gui/model/snapshot.py
@@ -433,10 +433,10 @@ def _job_data(self, index: QModelIndex, node: Node, role: int):
         if role == Qt.DisplayRole:
             _, data_name = COLUMNS[NodeType.REAL][index.column()]
             if data_name in [ids.CURRENT_MEMORY_USAGE, ids.MAX_MEMORY_USAGE]:
-                data = node.data.get(ids.DATA)
-                _bytes = data.get(data_name) if data else None
+                data = node.data
+                _bytes: Optional[str] = data.get(data_name) if data else None
                 if _bytes:
-                    return byte_with_unit(_bytes)
+                    return byte_with_unit(float(_bytes))
 
             if data_name in [ids.STDOUT, ids.STDERR]:
                 return "OPEN" if node.data.get(data_name) else QVariant()

diff --git a/tests/unit_tests/gui/simulation/test_run_dialog.py b/tests/unit_tests/gui/simulation/test_run_dialog.py
@@ -494,15 +494,15 @@ def test_run_dialog_memory_usage_showing(
         current_memory_value = widget._job_model.data(
             current_memory_column_proxy_index, Qt.DisplayRole
         )
-        assert current_memory_value == "50000"
+        assert current_memory_value == "50.00 kB"
 
         max_memory_column_proxy_index = widget._job_model.index(
             job_number, max_memory_column_index
         )
         max_memory_value = widget._job_model.data(
             max_memory_column_proxy_index, Qt.DisplayRole
         )
-        assert max_memory_value == "60000"
+        assert max_memory_value == "60.00 kB"
 
 
 @pytest.mark.usefixtures("use_tmpdir", "set_site_config", "using_scheduler")