add multiple option for select #526
Open
+131
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when option "multiple" is true, will process original value as array (joined on comma for now for display), and then pass array of selected options directly back to controller. Always adds a button because the change event is often fired spuriously when interacting with a multiselect.
|
getting an unrelated failure on "should be able to use bip_bool to change a boolean value using an image" locally on master, and now on CI as well. Not sure what is going on with that, will look into if I get a sec |
the block for Combustion.initialize! sets the old values for the test env that turn off digests, so the matcher for the image tag in "should be able to use bip_bool to change a boolean value using an image" works. also moving css files to standard application.css manifest avoids the complaints from rails about "Asset was not declared to be precompiled in production." for each of these.
|
This is great, although I'm getting |
|
@EmmaB good catch - I made a commit to deal with that, does it work better? |
|
@sbeam Sorry for the slow reply -- yes, that works perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when option "multiple" is true, will process original value as array
(joined on comma for now for display), and then pass array of selected
options directly back to controller. Always adds a button because the
change event is often fired spuriously when interacting with a
multiselect.
(there seems to be desire for this feature (eg, #285) and it's working in production for me. Feedback welcome - PS this gem is great 👍 )