Service to core #354
Open
Service to core #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacing final local variables
…tring baseUrl removed UrlBase moved grailsLinkGenerator use from AssetProcessorService to AssetMethodTagLib
Will not compile until asset-pipeline-core dependency is upgraded to new version that includes AssetPaths
rgoldberg
force-pushed
the
service-to-core
branch
from
e6fef78
to
8f6009d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved non-Grails instance methods from asset-pipeline-grails AssetProcessorService to static methods in new asset-pipeline-core AssetPaths
This is branched from the simple-cleanup PR, so please merge that first to isolate commits specific to this PR
Won't work until a new asset-pipeline-core version is released that includes bertramdev/asset-pipeline#97. Must include that new version in grails-asset-pipeline, and then everything will compile.