Remove maximum key length

beste · Jul 26, 2024 · 5f43f1f · 5f43f1f
1 parent 9f80ffc
commit 5f43f1f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
   encoding and a length of up to 64 characters. Implementing libraries MAY support additional characters and encodings
   or longer lengths, but must support at least that minimum.
   * Dashes (`-`) are now allowed in cache keys.
+  * The arbitrary maximum key length of 64 characters has been removed.
 
 
 ## [1.1.0] - 2024-03-02

diff --git a/src/CacheKey.php b/src/CacheKey.php
@@ -11,7 +11,7 @@ private function __construct(private readonly string $value) {}
 
     public static function fromString(string $value): self
     {
-        if (preg_match('/^[a-zA-Z0-9_.-]{1,64}$/u', $value) !== 1) {
+        if (preg_match('/^[a-zA-Z0-9_.-]+$/u', $value) !== 1) {
             throw InvalidArgument::invalidKey();
         }
 

diff --git a/tests/CacheKeyTest.php b/tests/CacheKeyTest.php
@@ -44,7 +44,6 @@ public static function invalidValues(): array
         return [
             'empty string' => [''],
             'invalid character' => ['\\'],
-            'too long' => [str_repeat('x', 65)],
         ];
     }
 }