This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
example/jsperf/ui.js: report both slower by xx% and slower by a factor of X
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…51% slower (✕ 2.0)`) as the computer is better at calculating both relative indicators than we are, and we can use our brain for the conclusions rather than the calculus.
| @@ -560,10 +560,11 @@ | |||
| if (_.indexOf(fastest, bench) > -1) { | |||
| // mark fastest | |||
| addClass(cell, text); | |||
There was a problem hiding this comment.
Why not just use a space, , instead of ?
There was a problem hiding this comment.
To prevent auto-wrapping the line between the times character and the factor itself, which would make it hard to read. This happened to me with some tests run using the customized jsperf example, so it'll happen to others too, I'm sure. ;-) Hence the non-breaking-space.
jdalton
force-pushed
the
master
branch
4 times, most recently
from
da00022
to
e156ebc
Compare
jdalton
force-pushed
the
master
branch
2 times, most recently
from
b08353e
to
f118abf
Compare
jdalton
force-pushed
the
master
branch
3 times, most recently
from
572f88b
to
10319e4
Compare
jdalton
force-pushed
the
master
branch
4 times, most recently
from
7d00d55
to
115bc9d
Compare
jdalton
force-pushed
the
master
branch
4 times, most recently
from
2f014b6
to
c732675
Compare
jdalton
force-pushed
the
master
branch
2 times, most recently
from
f263303
to
a37c36c
Compare
jdalton
force-pushed
the
master
branch
2 times, most recently
from
fa368bc
to
7c31726
Compare
jdalton
force-pushed
the
master
branch
2 times, most recently
from
e87b3c3
to
70a8b8b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(shown as
51% slower (✕ 2.0)) as the computer is better at calculating both relative indicators than we are, and we can use our brain for the conclusions rather than the calculus.(Of course one might want to see 'faster by a factor of X' instead, but this was more useful for my discussions.)
Don't know if you want this or want to keep the jsperf example as-is.
Anyway, thanks for all the work and the quick updates of the repo,
Cheers,
Ger