Reconnect #57

mhetzi · 2021-08-17T18:41:23Z

Hi,
Implementing Timers like this, fixes (at least with my model AC3829), #15 and #28.

Connection is currently 1 day stable, instead of 30 minutes.

Reconnect if no observation since 67 Seconds. Reconnect if connection is not complettely ready in 20 Seconds.

SamJongenelen · 2021-10-13T19:34:50Z

@betaboon could we review and merge this?

SamJongenelen · 2021-10-13T22:00:29Z

I tested this, and it indeed reconnects.

However, it does not recognize disconnects. Could this also be added? I power toggle the purifier during the day using sonoffs

mhetzi · 2021-10-14T15:06:52Z

@SamJongenelen did you mean like this?
9b6e3e9

SamJongenelen · 2021-10-15T12:55:46Z

Yes! I've tested the #9b6e3e9 fan.py and it indeed returns to 'unavailable' after the timeout, thank you!

SamJongenelen · 2021-10-15T15:51:33Z

Well I have some errors which I think are related

2021-10-15 17:08:50 ERROR (SyncWorker_2) [homeassistant] Error doing job: Task was destroyed but it is pending!
2021-10-15 17:08:50 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
RuntimeError: aclose(): asynchronous generator is already running
2021-10-15 17:08:50 ERROR (MainThread) [coap] Connection loss was not expected.

ronaldt80 · 2021-10-15T18:24:01Z

Did you update aioairctrl? I changed my manifest settings referring to an updated version. No issues since 72 hrs

…

-------- Original Message --------

On 15 Oct 2021, 17:51, Sam Jongenelen wrote: Well I have some errors which I think are related > 2021-10-15 17:08:50 ERROR (SyncWorker_2) [homeassistant] Error doing job: Task was destroyed but it is pending! 2021-10-15 17:08:50 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved RuntimeError: aclose(): asynchronous generator is already running 2021-10-15 17:08:50 ERROR (MainThread) [coap] Connection loss was not expected. — You are receiving this because you are subscribed to this thread. Reply to this email directly, [view it on GitHub](#57 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AMXEM3EV3CS2VREXGZ4YWPLUHBEZBANCNFSM5CKOHU2A). Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).

SamJongenelen · 2021-10-15T19:44:32Z

Good catch no I didnt, will install fully when on pc again

Try to get rid of a few errors, while trying to reconnect

ronaldt80 · 2021-10-17T14:50:08Z

thanks @mhetzi ; solved my issues it seems. With the new aioairctrl and your changes the integration is working again (AC2889/10; FW 64.3)

Seeing @betaboon is no longer maintaining this fork; would it not be easier to move over to your fork as "main" coap version?

ronaldt80 · 2021-10-17T18:47:46Z

whilst the airpurifier is running i do get flooded with errors - my line numbers deviate but its around these two pieces of code

    async def reset_connection(self, endIt=False):
        try:
            if self._observer_task is not None:
                self._observer_task.cancel()
                await self._observer_task
            if self._client is not None:
                await self._client.shutdown()
        except:
            _LOGGER.exception("Reset Connection: Cleanup of old connection failed!")
        if not endIt:
            await self.init()
            await self.async_added_to_hass()

    async def _observe_status(self) -> None:
        async for status in self._client.observe_status():
            self._device_status = status
            self.schedule_update_ha_state()
            self._timer.reset()

which generates the following error:

Logger: custom_components.philips_airpurifier_coap.fan
Source: custom_components/philips_airpurifier_coap/fan.py:363
Integration: philips_airpurifier_coap (documentation)
First occurred: 16:55:40 (50 occurrences)
Last logged: 20:37:00

Reset Connection: Cleanup of old connection failed!
Traceback (most recent call last):
  File "/config/custom_components/philips_airpurifier_coap/fan.py", line 439, in _observe_status
    async for status in self._client.observe_status():
  File "/usr/local/lib/python3.9/site-packages/aioairctrl/coap/client.py", line 92, in observe_status
    async for response in requester.observation:
  File "/usr/local/lib/python3.9/site-packages/aiocoap/protocol.py", line 1083, in __anext__
    result = await self._future
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/config/custom_components/philips_airpurifier_coap/fan.py", line 363, in reset_connection
    await self._observer_task
asyncio.exceptions.CancelledError

and

Logger: coap
Source: /usr/local/lib/python3.9/site-packages/aiocoap/transports/udp6.py:525
First occurred: 16:56:07 (245 occurrences)
Last logged: 20:37:21

Connection loss was not expected.

ronaldt80 · 2021-10-17T18:50:59Z

Note, the purifier was on between 16.55 and 18:26 and has been off ever since. Behaviour takes place both in on and off state.

mhetzi · 2021-10-17T19:46:08Z

@ronaldt80
The first exception should be history with this change.
Connection loss was not expected. is from the COAP API, dont know what to do about this one. Sorry

About switching branches/forks, who will maintain this integration in the long run?

ronaldt80 · 2021-10-18T07:57:17Z

thanks - the COAP API error persists indeed, but only when the purifier is off. The other errors are gone now. Side effect, when restarting HA whilst the purifier is off it now takes longer for the purfier to become available (ca. 3minutes in my case). Will test some more over the coming days. Thanks!

As for the ownership of the branches / forks - good point, unfortunately my python skills are limited to some cutting and pasting so not the ideal candidate myself I fear.

SamJongenelen · 2021-10-18T11:02:25Z

Did you update aioairctrl? I changed my manifest settings referring to an updated version. No issues since 72 hrs
…
-------- Original Message --------
On 15 Oct 2021, 17:51, Sam Jongenelen wrote: Well I have some errors which I think are related > 2021-10-15 17:08:50 ERROR (SyncWorker_2) [homeassistant] Error doing job: Task was destroyed but it is pending! 2021-10-15 17:08:50 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved RuntimeError: aclose(): asynchronous generator is already running 2021-10-15 17:08:50 ERROR (MainThread) [coap] Connection loss was not expected. — You are receiving this because you are subscribed to this thread. Reply to this email directly, [view it on GitHub](#57 (comment)), or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

@ronaldt80
I checked my manifest (this branch version), its using v0.2.1 - you too?


{
  "domain": "philips_airpurifier_coap",
  "name": "Philips AirPurifier (with CoAP)",
  "version": "0.7.0",
  "documentation": "https://github.com/betaboon/philips-airpurifier-coap",
  "dependencies": [],
  "codeowners": ["@betaboon"],
  "requirements": [
    "aioairctrl @ git+https://github.com/betaboon/[email protected]"
  ]
}

ronaldt80 · 2021-10-18T15:21:44Z

@SamJongenelen I am on HASS OS so cannot manually install different aioairctrl versions- to achieve the same I changed my manifest to ensure it references the updated file - a full OS reboot was required to pull the new file (in my case), code is as follows:

{
  "domain": "philips_airpurifier_coap",
  "name": "Philips AirPurifier (with CoAP)",
  "version": "0.7.0",
  "documentation": "https://github.com/betaboon/philips-airpurifier-coap",
  "dependencies": [],
  "codeowners": ["@betaboon"],
  "requirements": [
    "aioairctrl @ git+https://github.com/Peter-J/aioairctrl"
  ]
}

SamJongenelen · 2021-10-18T18:15:20Z

@SamJongenelen I am on HASS OS so cannot manually install different aioairctrl versions- to achieve the same I changed my manifest to ensure it references the updated file - a full OS reboot was required to pull the new file (in my case), code is as follows:
{
  "domain": "philips_airpurifier_coap",
  "name": "Philips AirPurifier (with CoAP)",
  "version": "0.7.0",
  "documentation": "https://github.com/betaboon/philips-airpurifier-coap",
  "dependencies": [],
  "codeowners": ["@betaboon"],
  "requirements": [
    "aioairctrl @ git+https://github.com/Peter-J/aioairctrl"
  ]
}

Me too homeassistantOs. I small try the peter j airctrl

ronaldt80 · 2021-10-31T08:21:17Z

Any one else experience the coap connection loss error after incorporating the changes which otherwise solve the disconnect issue?

Logger: coap
Source: /usr/local/lib/python3.9/site-packages/aiocoap/transports/udp6.py:525
First occurred: 07:42:44 (66 occurrences)
Last logged: 08:17:20

Connection loss was not expected.

I have thousands a day, think after a while it chokes HA Core

SamJongenelen · 2021-10-31T12:30:10Z

You are right. The logging expands when running for a long time. Exact same log timestamps, see beneith after ~12h uptime

2021-10-31 13:23:26 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:23:26 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:23:26 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:23:26 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:32:48 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:32:48 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:32:48 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:36:49 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:39:50 ERROR (MainThread) [coap] Connection loss was not expected.
2021-10-31 13:39:50 ERROR (MainThread) [coap] Connection loss was not expected.

kongo09 · 2021-12-07T21:40:22Z

About switching branches/forks, who will maintain this integration in the long run?

At the moment, nobody really does. It would be great to have someone take over who at least occasionally could take a brief look at stuff with more than rookie skills.

@betaboon Or is there hope that you find some time after Christmas, just like you did last year?

SamJongenelen · 2021-12-10T19:48:04Z

I havent had any choke issues on HA lately

kongo09 · 2022-04-07T20:05:13Z

@mhetzi As the integration seems unmaintained here, I've attempted a bit of a rewrite based on a fork of this. It's now quite comprehensive in terms of features, but my Python skills are acquired on the way, so I struggle a bit with integrating your timer approach. Do you think you could help out?

mhetzi · 2022-04-08T14:05:33Z

@kongo09 How can i help you?

kongo09 · 2022-04-08T14:19:35Z

@kongo09 How can i help you?

Maybe you can take a look at the rewrite and suggest how to integrate the Timer? I've put your timer code into a separate file for clarity, but it is not integrated. I'm not sure if it should deal with the coordinator, or maybe it is even better placed in the aioairctrl library? What's your suggestion?

mhetzi · 2022-04-08T15:09:41Z

I think putting it in Coordinator would be the easiest.
On my last experiments killing and recreating the client was the most stable solution.
The library sometimes thinks its connected, but it´s not.

kongo09 · 2022-04-08T15:24:24Z

Do you think you could help out with a pull request?

mhetzi · 2022-04-08T15:54:28Z

ok

Reconnect

9cf3a0d

Reconnect if no observation since 67 Seconds. Reconnect if connection is not complettely ready in 20 Seconds.

Disconnected Test

9b6e3e9

Try to get unavailable state more precise

ce6e7cf

Try to get rid of a few errors, while trying to reconnect

GSzabados mentioned this pull request Oct 17, 2021

Flush output when observing betaboon/aioairctrl#5

Open

Another Exception is gone

12328df

balu- mentioned this pull request Feb 20, 2022

Observ state seems to be lost after a while balu-/philips-airpurifier-coapMqtt#1

Closed

mhetzi mentioned this pull request Apr 8, 2022

Timer kongo09/philips-airpurifier-coap#5

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reconnect #57

Reconnect #57

mhetzi commented Aug 17, 2021

SamJongenelen commented Oct 13, 2021

SamJongenelen commented Oct 13, 2021 •

edited

Loading

mhetzi commented Oct 14, 2021

SamJongenelen commented Oct 15, 2021 •

edited

Loading

SamJongenelen commented Oct 15, 2021

ronaldt80 commented Oct 15, 2021 via email

SamJongenelen commented Oct 15, 2021 •

edited

Loading

ronaldt80 commented Oct 17, 2021

ronaldt80 commented Oct 17, 2021

ronaldt80 commented Oct 17, 2021

mhetzi commented Oct 17, 2021

ronaldt80 commented Oct 18, 2021

SamJongenelen commented Oct 18, 2021 •

edited

Loading

ronaldt80 commented Oct 18, 2021

SamJongenelen commented Oct 18, 2021

ronaldt80 commented Oct 31, 2021

SamJongenelen commented Oct 31, 2021 •

edited

Loading

kongo09 commented Dec 7, 2021

SamJongenelen commented Dec 10, 2021

kongo09 commented Apr 7, 2022

mhetzi commented Apr 8, 2022

kongo09 commented Apr 8, 2022

mhetzi commented Apr 8, 2022

kongo09 commented Apr 8, 2022

mhetzi commented Apr 8, 2022

Reconnect #57

Reconnect #57

Conversation

mhetzi commented Aug 17, 2021

SamJongenelen commented Oct 13, 2021

SamJongenelen commented Oct 13, 2021 • edited Loading

mhetzi commented Oct 14, 2021

SamJongenelen commented Oct 15, 2021 • edited Loading

SamJongenelen commented Oct 15, 2021

ronaldt80 commented Oct 15, 2021 via email

SamJongenelen commented Oct 15, 2021 • edited Loading

ronaldt80 commented Oct 17, 2021

ronaldt80 commented Oct 17, 2021

ronaldt80 commented Oct 17, 2021

mhetzi commented Oct 17, 2021

ronaldt80 commented Oct 18, 2021

SamJongenelen commented Oct 18, 2021 • edited Loading

ronaldt80 commented Oct 18, 2021

SamJongenelen commented Oct 18, 2021

ronaldt80 commented Oct 31, 2021

SamJongenelen commented Oct 31, 2021 • edited Loading

kongo09 commented Dec 7, 2021

SamJongenelen commented Dec 10, 2021

kongo09 commented Apr 7, 2022

mhetzi commented Apr 8, 2022

kongo09 commented Apr 8, 2022

mhetzi commented Apr 8, 2022

kongo09 commented Apr 8, 2022

mhetzi commented Apr 8, 2022

SamJongenelen commented Oct 13, 2021 •

edited

Loading

SamJongenelen commented Oct 15, 2021 •

edited

Loading

SamJongenelen commented Oct 15, 2021 •

edited

Loading

SamJongenelen commented Oct 18, 2021 •

edited

Loading

SamJongenelen commented Oct 31, 2021 •

edited

Loading