Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise api recherche entreprises gouv.fr #2929

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

JalilArfaoui
Copy link
Contributor

Closes #2879

Supercedes #2895 : Inclu le refactor préalable qui n'avait jamais été mergé.

@JalilArfaoui JalilArfaoui self-assigned this Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for nostalgic-mahavira-52b682 canceled.

Name Link
🔨 Latest commit 17df2d8
🔍 Latest deploy log https://app.netlify.com/sites/nostalgic-mahavira-52b682/deploys/6627e15c666614000878e087

Copy link

♿ Checklist accessibilité :

Quelques points à vérifier pour maintenir une bonne accessibilité du site :

  • les labels des boutons et des liens sont descriptifs
  • un aria-label est ajouté pour préciser l'action d'un bouton ou d'un lien pour les lecteurs d'écran
  • les couleurs du texte est suffisamment constratée par rapport à la couleur de background
  • la fonctionnalité ajoutée est utilisable en navigant au clavier et avec un lecteur d'écran
  • les changements de contexte sont évités ou au minimum annoncés

Plus de détails sur chaque point dans le guide Notion.

@JalilArfaoui JalilArfaoui force-pushed the feat/utilise-api-recherche-entreprises-gouv branch from 64e60f3 to 5b279f4 Compare April 16, 2024 16:14
@JalilArfaoui JalilArfaoui force-pushed the feat/utilise-api-recherche-entreprises-gouv branch 3 times, most recently from 4c801c3 to 10bb93c Compare April 17, 2024 07:14
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 08:03 Inactive
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 08:03 Inactive
Copy link

github-actions bot commented Apr 17, 2024

Copy link
Collaborator

@johangirod johangirod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top, c'est bien plus clair

site/source/components/company/SearchDetails.tsx Outdated Show resolved Hide resolved
site/source/hooks/useRepositories.ts Show resolved Hide resolved
site/source/hooks/useSearchCompany.ts Show resolved Hide resolved
@JalilArfaoui JalilArfaoui force-pushed the feat/utilise-api-recherche-entreprises-gouv branch from 39e2ffe to 71bf1c2 Compare April 17, 2024 11:38
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 11:44 Inactive
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 11:44 Inactive
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 11:54 Inactive
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 11:54 Inactive
@JalilArfaoui JalilArfaoui force-pushed the feat/utilise-api-recherche-entreprises-gouv branch from a404537 to e005f50 Compare April 17, 2024 12:01
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 12:05 Inactive
@github-actions github-actions bot temporarily deployed to 2929 April 17, 2024 12:06 Inactive
@JalilArfaoui JalilArfaoui force-pushed the feat/utilise-api-recherche-entreprises-gouv branch from e005f50 to 17df2d8 Compare April 23, 2024 16:27
@github-actions github-actions bot temporarily deployed to 2929 April 23, 2024 16:35 Inactive
@JalilArfaoui JalilArfaoui merged commit 2599d46 into master Apr 23, 2024
39 checks passed
@JalilArfaoui JalilArfaoui deleted the feat/utilise-api-recherche-entreprises-gouv branch April 23, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changer l'API de recherche d'entreprise
2 participants