Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new app frontend #2714

Merged
merged 11 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app-front/.env.example
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
NEXT_PUBLIC_API_URL=
NEXT_PUBLIC_SEARCH_URL=
NEXT_PUBLIC_SEARCH_TOKEN=
NEXT_PUBLIC_PC_DOMAIN=
NEXT_PUBLIC_PC_REDIRECT_URI=
NEXT_PUBLIC_PC_CLIENT_ID=
NEXT_PUBLIC_PC_SCOPES=

3 changes: 3 additions & 0 deletions app-front/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": ["next/core-web-vitals", "next/typescript"]
}
36 changes: 36 additions & 0 deletions app-front/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js
.yarn/install-state.gz

# testing
/coverage

# next.js
/.next/
/out/

# production
/build

# misc
.DS_Store
*.pem

# debug
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# local env files
.env*.local

# vercel
.vercel

# typescript
*.tsbuildinfo
next-env.d.ts
36 changes: 36 additions & 0 deletions app-front/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
This is a [Next.js](https://nextjs.org) project bootstrapped with [`create-next-app`](https://nextjs.org/docs/app/api-reference/cli/create-next-app).

## Getting Started

First, run the development server:

```bash
npm run dev
# or
yarn dev
# or
pnpm dev
# or
bun dev
```

Open [http://localhost:3000](http://localhost:3000) with your browser to see the result.

You can start editing the page by modifying `app/page.tsx`. The page auto-updates as you edit the file.

This project uses [`next/font`](https://nextjs.org/docs/app/building-your-application/optimizing/fonts) to automatically optimize and load [Geist](https://vercel.com/font), a new font family for Vercel.

## Learn More

To learn more about Next.js, take a look at the following resources:

- [Next.js Documentation](https://nextjs.org/docs) - learn about Next.js features and API.
- [Learn Next.js](https://nextjs.org/learn) - an interactive Next.js tutorial.

You can check out [the Next.js GitHub repository](https://github.com/vercel/next.js) - your feedback and contributions are welcome!

## Deploy on Vercel

The easiest way to deploy your Next.js app is to use the [Vercel Platform](https://vercel.com/new?utm_medium=default-template&filter=next.js&utm_source=create-next-app&utm_campaign=create-next-app-readme) from the creators of Next.js.

Check out our [Next.js deployment documentation](https://nextjs.org/docs/app/building-your-application/deploying) for more details.
45 changes: 45 additions & 0 deletions app-front/next.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/** @type {import('next').NextConfig} */

const nextConfig = {
pageExtensions: ["js", "jsx", "ts", "tsx"],
output: "export",
trailingSlash: true,
reactStrictMode: true, // Recommended for the `pages` directory, default in `app`.
images: {
dangerouslyAllowSVG: true,
unoptimized: true,
remotePatterns: [
{
protocol: "https",
hostname: "**",
port: "",
pathname: "**",
},
],
},
Datayama38 marked this conversation as resolved.
Show resolved Hide resolved
webpack: (config, { webpack, isServer }) => {
config.module.rules.push({
test: /\.woff2$/,
type: "asset/resource",
});

const envs = {};

Object.keys(process.env).forEach((env) => {
if (env.startsWith("NEXT_PUBLIC_")) {
envs[env] = process.env[env];
}
});
Comment on lines +28 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add validation for required environment variables

The current implementation blindly collects all NEXT_PUBLIC_ variables without validation.

+const REQUIRED_ENV_VARS = [
+  'NEXT_PUBLIC_API_URL',
+  'NEXT_PUBLIC_SEARCH_URL'
+];
+
 Object.keys(process.env).forEach((env) => {
   if (env.startsWith("NEXT_PUBLIC_")) {
     envs[env] = process.env[env];
   }
 });
+
+REQUIRED_ENV_VARS.forEach((env) => {
+  if (!envs[env]) {
+    throw new Error(`Missing required environment variable: ${env}`);
+  }
+});
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Object.keys(process.env).forEach((env) => {
if (env.startsWith("NEXT_PUBLIC_")) {
envs[env] = process.env[env];
}
});
const REQUIRED_ENV_VARS = [
'NEXT_PUBLIC_API_URL',
'NEXT_PUBLIC_SEARCH_URL'
];
Object.keys(process.env).forEach((env) => {
if (env.startsWith("NEXT_PUBLIC_")) {
envs[env] = process.env[env];
}
});
REQUIRED_ENV_VARS.forEach((env) => {
if (!envs[env]) {
throw new Error(`Missing required environment variable: ${env}`);
}
});


if (!isServer) {
config.plugins.push(
new webpack.DefinePlugin({
"process.env": JSON.stringify(envs),
}),
);
}
return config;
},
};

module.exports = nextConfig;
Loading
Loading