Target netstandard2.0 and use the new csproj format. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add endpoints listEvents and listRunnerBook. Use keep alive. RescriptClient seems to be broken.
Asura5
reviewed
Oct 5, 2023
| <ImplicitUsings>disable</ImplicitUsings> | ||
| <Nullable>disable</Nullable> | ||
| <LangVersion>8</LangVersion> | ||
| <VersionPrefix>1.0.1</VersionPrefix> |
There was a problem hiding this comment.
This is going to be a breaking change for some people - should it be at least a minor version revision, if not major?
|
The thing is pretty broken already! Happy to tody it up a bit; it was mainly for my own use but I thought I'd create a merge request on the off-chance that it coulld help anyone else. I would suggest.
|
|
Hello? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoints listEvents and listRunnerBook.
Use keep alive.
RescriptClient seems to be broken.