Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove dependency on asset/ directory existence. #51

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

chaosteil
Copy link
Contributor

This PR simplifies the handling with the asset/ directory. Just a few less instructions for someone to follow who wants to quickly publish a release.

Note than in windows instead of silently passing through, it force-creates an empty asset/ directory instead (and does not error if it does already exist), but which still results in an empty zip file with only the binary.

Tested that it works by running the template with the assets present: https://github.com/chaosteil/bevy_github_ci_template/actions/runs/8217244209 resulting in release https://github.com/chaosteil/bevy_github_ci_template/releases/tag/v0.0.1-test

and as well as running the template without the assets directory present:
https://github.com/chaosteil/bevy_github_ci_template/actions/runs/8217285995 resulting in release https://github.com/chaosteil/bevy_github_ci_template/releases/tag/v0.0.1-test-assetremove

Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I did not test it locally.

I would recommend adding comments on why it's || true all of the cp commands, but I won't block on it. :)

@alice-i-cecile alice-i-cecile merged commit d8c86ea into bevyengine:main Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants