Fix: preserve newlines in stream output rendered with ansithml #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other HTML-rendering packages (
chromaorgoldmark),ansihtmldoes not wrap its output in<pre>tags, so newline characters\nare ignored in the HTML output.This fix only applies to
adapters.AnsiHtmland not to the broaderextension.NewStream, because this is specific toansihtml-- other stream renderers may already render the contents as pre-formatted text, or may want to display it altogether differently.Added an executable example to quickly get the feeling for what nb is capable of and how it can be extended.