Support earlier notebook versions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decoder for v4.4 is reused for all notebooks with major version 4, because they their differences do not affect how the notebooks are rendered: - v4.5 requires that each cell has a unique ID - versions < v4.3 do not have the 'code_cell.metadata.execution' field, which holds the code's execution time. They also do not have 'raw_cell.metadata.jupyterf.source_hidden' which controls if the source is hidden. This has a default behaviour in 'nb' and is probably not that important anyways. Finally, they miss metadata.title field, which is currently not used also in v4.4 notebooks.
Prior to v4.0: - top-level 'worksheets' contained multiple worksheets with the actual 'cells' - execution_results was called pyout - error output was called pyerr - code cell 'source' was called 'input'; execution_count was called prompt_number - mime-bundle explicitly defined keys for all mime-tyipes which it supported and had to be decoded differently BREAKING: decode.Decoder interface not inlcudes ExtractCells method to handle the deprecation of top-level 'worksheets'
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 81.56% 81.86% +0.30%
==========================================
Files 11 11
Lines 575 579 +4
==========================================
+ Hits 469 474 +5
+ Misses 85 83 -2
- Partials 21 22 +1 ☔ View full report in Codecov by Sentry. |
Turns out, v1 and v2 only differ in how Jupyter interprets them, not in the schema itself. We can use the same decoder we use for v3.
This has no logic implications, but it feels like multiple instances are unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds decoders for Jupyter Notebooks
v4.*,v3.0,v2.0, andv1.0.It turns out v1 and v2 are not different from v3 in any way that affects the rendering, so the same decoder can be reused for all notebooks in the three formats.
BREAKING :
decode.Decoderrequires an additional method, so the existing implementations had to be updated.