Wrap notebook contents in a <div class="jp-Notebook"> #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for custom renderers to do that on their own
Drop superficial nodes with '\n' content --> their only purpose is making the generated HTML more readable. They should be disregarded during tests.
CSS, if any, is now written during the call to WrapAll. This only happens once per notebook, so wrapping CSSWriter into WriterOnce is redundant. Removed WriterOnce, it's not used anywhere else. Added a test case for SVG images in html.Renderer.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 81.86% 82.60% +0.74%
==========================================
Files 11 11
Lines 579 575 -4
==========================================
+ Hits 474 475 +1
+ Misses 83 76 -7
- Partials 22 24 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping the entire notebook in a separate div allows applying common styling for all cells.