Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL option for clients to allow non-standard port options #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cazzar
Copy link

@Cazzar Cazzar commented Jul 8, 2020

This Pull Request allows a user to configure the option ssl to enforce use of SSL or no SSL within the tunnel
It was made in such a way that the default of null will retain the current logic that expose uses which is port === 443

It is useful if you want to host expose on something other than port 443 while still using SSL.
Something else that could be added is warning a user if they use 'ssl' => false, 'port' => 443 as most browsers will reject this

My git skills failed me on #89 so I recreated the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant