Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Handle Panel Domains #15

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

bezhanSalleh
Copy link
Owner

@bezhanSalleh bezhanSalleh commented Nov 17, 2023

Closes #13

@bezhanSalleh bezhanSalleh merged commit 14da833 into 3.x Nov 17, 2023
3 of 10 checks passed
@andrewdwallo
Copy link
Contributor

andrewdwallo commented Nov 18, 2023

@bezhanSalleh This PR did not fix #14 or #12. Your suggestion or "fix" to use a different render hook does not work as well... unless I put the panel switch button inside the page body or something. The only thing that does work with topNavigation enabled is using the simple method for the panel switch, nothing else.

When using topNavigation, clicking on the button to open the panel switch modal does absolutely nothing.

@bezhanSalleh bezhanSalleh deleted the feature/handle-panel-domains branch November 18, 2023 12:53
@bezhanSalleh
Copy link
Owner Author

There was supposed to be an issue regarding what the title of the PR says weird 🤔. Anyhow, I haven't looked into top navigation issue and this is for what it says. Apologies for misleading comment.

@andrewdwallo
Copy link
Contributor

Sorry. I was just commenting here because I noticed that you closed both of the issues that I mentioned above saying that this PR fixes those issues. That is what I was commenting about. I wasn't commenting about the "Handle Domains" feature.

Anyways, I found the fix for both #14 and #12 and will be submitting a PR for it shortly. Thanks.

@bezhanSalleh
Copy link
Owner Author

Sweet,I have reopened them so be sure to mention it in your PR.

@andrewdwallo
Copy link
Contributor

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants