Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Filament Panel Urls #21

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

gchaumont
Copy link
Contributor

Currently, panel urls are not resolved correctly when they define both a path and a domain. Also the handling of http vs https is hardcoded. This uses Filament's panel home url or panel url which will generate the correct url with scheme, domain and path.

Currently, panel urls are not resolved correctly when panels define both a path and a domain. Also the handling of http vs https is hardcoded. This uses Filament's default home url or panel url.
Copy link

what-the-diff bot commented Feb 5, 2024

PR Summary

  • Improved URL Acquisition Logic
    The logic for getting the path to the panel in the panel-switch-menu.blade.php file has been refined. Instead of creating the URL based on the environments and panel domains, it now efficiently uses the getHomeUrl() or getUrl() methods of the Filament\Panel object, leading to more reliable and consistent outcomes.

Fixes Url resolution error
Always display the link so we can switch back to the first panel when spa() mode is active.
@xalabama
Copy link

Any plans when this changes will merged into a new release?

@bojmaliev
Copy link

Any plans when this changes will merged into a new release?

+1

@bezhanSalleh
Copy link
Owner

This weekend or even before that

@bezhanSalleh bezhanSalleh merged commit e4e9e1b into bezhanSalleh:3.x Aug 7, 2024
1 check passed
@bezhanSalleh
Copy link
Owner

Currently, panel urls are not resolved correctly when they define both a path and a domain. Also the handling of http vs https is hardcoded. This uses Filament's panel home url or panel url which will generate the correct url with scheme, domain and path.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants