Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance RoleResource Table with Configurable Guard Name Grouping #438

Closed
wants to merge 1 commit into from

Conversation

krishzzi
Copy link

@krishzzi krishzzi commented Nov 4, 2024

Description

This commit introduces a feature that allows for the grouping of multiple guard_name entries within the RoleResource table, improving usability and clarity when managing roles associated with various guards. By enabling the grouping of guard_name entries, users can more easily navigate and organize the roles assigned to different guards, resulting in a more logical and visually appealing interface.

To facilitate this enhancement, a new configuration option has been added:

'table_group_by_guard_name' => true // Set to true or false

Copy link

what-the-diff bot commented Nov 4, 2024

PR Summary

  • Introduction of a new configuration option
    A new configuration option named table_group_by_guard_name has been added to the filament-shield.php file. This will provide greater customization abilities to the user.

  • Modification of table method
    The table method in the file RoleResource.php has been updated. Now it sets a default grouping by guard_name depending on the setting of the newly introduced configuration option. This change improves the default behavior of the program and can make the output data more organized and easy to analyze.

@bezhanSalleh
Copy link
Owner

Thanks, but these are app/dev specific customizations and since the resource has more options to customize i have improved the shield:publish command, which will be available in 3.3.0 and we will remove resource specific configurations completely in later releases given you have full control over it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants