Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HasPageShield.php #440

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

naingwin
Copy link
Contributor

@naingwin naingwin commented Nov 6, 2024

add required parameter in shouldRegisterNavigation() and canAccess() methods to compatible with filament

add required parameter in shouldRegisterNavigation() and canAccess() methods to compatible with filament
Copy link

what-the-diff bot commented Nov 6, 2024

PR Summary

  • Enhancement of shouldRegisterNavigation method
    The method has been updated to accept an additional option - an array of parameters. This gives the ability to tweak the functionality of the method based on more variable inputs.

  • Enhancement of canAccess method
    This method too, similar to the above, can now accept an optional array of parameters. This enables more flexible usage of this method.

These updates will provide flexibility and adaptability, giving us more control over our methods, allowing them to cater to a variety of situations.

@bezhanSalleh bezhanSalleh merged commit 98ab121 into bezhanSalleh:3.x Nov 9, 2024
1 check passed
@naingwin naingwin deleted the patch-1 branch November 15, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants