issue-39: fix privacy provider #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NJahreis
force-pushed
the
issue-39_privacyprovider
branch
from
0c19873 to
f0a6988
Compare
TODOs: - 75: Field item does not exist in table verbalfeedback_response - 297ff: Response has no "type" and api::QTYPE_RATED is not defined, helper::get_scale_values is not defined - 234ff : verbalfeedback_question does not exist; verbalfeedback_i_criterion has no fields verbalfeedback or instanceid
NJahreis
force-pushed
the
issue-39_privacyprovider
branch
from
f0a6988 to
9291ee1
Compare
srobotta
force-pushed
the
main
branch
15 times, most recently
from
c498aa2 to
bbd48eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi as discussed in #39 I noticed some issues in the privacy provider. I started working on the necessary changes but got a bit stuck for now as the plugin has changed quite a bit since the provider class was initialy written.
I noticed that these point need work at the very least still:
TODOs: