Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to show/hide the history and the correct answer #13

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

PhilippImhof
Copy link
Contributor

This PR adds two options that allow the teacher to decide whether or not to include the history of saved answers and whether or not to include the correct answer.

I took the liberty to do some major changes to archive_options.php, because using another parent class made much of the existing code redundant.

The PR includes a behat test for the two options.

@lucaboesch
Copy link
Contributor

Thanks so much @PhilippImhof for this improvement, which I'm going to merge.
I've looked at the used strings and propose a slight amendment which I will edit in:

☐ Include response history table
☐ Include correct answer banner

Because I was seeing the green ✅ ticks in the questions and thought "Hey, this distinguishes the correct answers, too, doesn't it?".

I noticed an additional thing, which is that if there is no attempt at all, the report just shows those
☐ Include response history table
☐ Include correct answer banner
options and the "Show report" button again. You might think the button didn't work. A notice with the string "There are no attempts to show" (quiz|noattemptstoshow) could come in handy.
I will create an issue.

Best,
Luca

@lucaboesch lucaboesch merged commit 51a82a6 into bfh:master Nov 11, 2023
38 checks passed
@PhilippImhof PhilippImhof deleted the options branch November 12, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants