Skip to content

Commit

Permalink
Fix issue #16 and #17 with broken context menu
Browse files Browse the repository at this point in the history
  • Loading branch information
srobotta committed Aug 20, 2024
1 parent d127f2d commit 9fb7402
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 6 deletions.
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
moodle-tiny_fontcolor
========================

![Release](https://img.shields.io/badge/Release-0.6-blue.svg)
![Release](https://img.shields.io/badge/Release-0.7-blue.svg)
[![Moodle Plugin CI](https://github.com/bfh/moodle-tiny_fontcolor/workflows/Moodle%20Plugin%20CI/badge.svg?branch=main)](https://github.com/bfh/moodle-tiny_fontcolor/actions?query=workflow%3A%22Moodle+Plugin+CI%22+branch%3Amain)
[![PHP Support](https://img.shields.io/badge/php-7.4--8.3-blue)](https://github.com/bfh/moodle-tiny_fontcolor/action)
[![Moodle Support](https://img.shields.io/badge/Moodle-4.1--4.4-orange)](https://github.com/bfh/moodle-tiny_fontcolor/actions)
Expand Down Expand Up @@ -61,6 +61,12 @@ over the appropriate color square.

## Version History

### 0.7
- Fix [HTML areas without files seem to fail with the tiny_fontcolor enabled #16](https://github.com/bfh/moodle-tiny_fontcolor/issues/16) and
[TinyMCE fails when creating a qtype_multichoice question #17](https://github.com/bfh/moodle-tiny_fontcolor/issues/17). The introduced context menu items in 0.6 didn't show up under
some conditions (e.g. in mc questions for answers and feedback) when there was no previously
defined contextmenu.

### 0.6
- [Add quickbar support #14](https://github.com/bfh/moodle-tiny_fontcolor/issues/14)
by [Thomas Ludwig](https://github.com/tholudwig)
Expand Down
2 changes: 1 addition & 1 deletion amd/build/configuration.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion amd/build/configuration.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion amd/src/configuration.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ const configureMenu = (menu) => {
};

const configureContextMenu = (menu) => {
return addContextmenuItem(menu ?? '', '|', forecolor, backcolor);
if (!menu) {
menu = '';
}
return addContextmenuItem(menu, '|', forecolor, backcolor);
};

export const configure = (instanceConfig) => {
Expand Down
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'tiny_fontcolor';
$plugin->release = '0.6';
$plugin->version = 2024062700;
$plugin->release = '0.7';
$plugin->version = 2024082000;
$plugin->requires = 2022112800;
$plugin->maturity = MATURITY_STABLE;
$plugin->supported = [401, 404];
Expand Down

0 comments on commit 9fb7402

Please sign in to comment.