Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified for Python 3.9+ and Cython 3.0+ #46

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

AminAlam
Copy link

@AminAlam AminAlam commented Nov 9, 2023

fa2/fautil.pxd removed from build process as Cython can not detect this file format and its not needed for building process

*update:

Please look at issue #48 and use "fa2_modified" module for the best performance instead of using thic pull req.

fa2/fautil.pxd removed from build process as Cython can not detect this file format and its not needed for building process
Copy link

@NajaJean NajaJean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixed my problems!

@WeipengMO
Copy link

WeipengMO commented Feb 26, 2024

Thanks! It solves the problem I encountered during installation error: unknown file type '.pxd' (from 'fa2/fa2util.pxd')

@Minsmind
Copy link

saved my day! Here Python 3.8.18, Cython version 3.0.0. It worked!

@AminAlam
Copy link
Author

As I've added more commits to this PR, it's noteworthy to mention that the first commit is enough to solve the problem, and the rest are just modifications for the python package and are unrelated to the proposed problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants