Fix unresolved types #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2022 20:59
Removing types subfolder and moving the types right to the root next to the index.js. This is because it seems that TypeScript cannot resolve the types unless they are right at the root when the published package is included as a dependency in another project
|
@bhoriuchi this would be fantastic to have working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this package seems to be deployed from the
distfolder I moved the types to the "root" being the root of dist. This is because when the package is installed on other projects it seems that TypeScript cannot find the types from thetypessubfolder. Also added a little note for other users to change their tsconfig module resolution tonode. Otherwise the types are not found.If this gets merged, it might be good idea to create a whole new release, so that the release tags on github align with the release numbers on npm