Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze version numbers in requirements.txt to prevent accidentally incompatible upgrades #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zylos146
Copy link

The requirements.txt file was using >= syntax for the version numbers.
This meant the PySide6 dependency automatically upgraded beyond 6.7.0 which is incompatible with the syntax used by line 49 of src/cycle.py

  fl.addRow("Cycle time (s)", self.cycle_time_sb)
  fl.addRow(self.pb_start, self.pb_stop)

Adjusting this incompatibility likely wouldn't be hard, but I would recommend fixing python version numbers anyways.
Other languages like NodeJS, and even other python utilities like PyEnv, favor using Package Lock files which enforce only intentional upgrades.

I am basing this off Equivalent of package.json and package-lock.json for pip

I've run pip3 freeze -r requirements.txt after getting all of the right package versions installed which is how the below file was generated.

I've also specified in the readme that Python 3.11 should be used. pyqtdarktheme does not support Python 3.12 yet and enforces Requires-Python <3.12,>=3.7

@zylos146
Copy link
Author

This likely doesn't address fully the build side of the system. The version fixing in the project TOML would need to be updated to limit <3.12 python, and I'm concerned how this would affect the package requirements in the built version + setup.cfg. People will be running this on installed systems and may not have exactly the versions in the frozen requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant