Freeze version numbers in requirements.txt to prevent accidentally incompatible upgrades #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirements.txt file was using
>=
syntax for the version numbers.This meant the PySide6 dependency automatically upgraded beyond
6.7.0
which is incompatible with the syntax used by line 49 of src/cycle.pyAdjusting this incompatibility likely wouldn't be hard, but I would recommend fixing python version numbers anyways.
Other languages like NodeJS, and even other python utilities like PyEnv, favor using Package Lock files which enforce only intentional upgrades.
I am basing this off Equivalent of
package.json
andpackage-lock.json
forpip
I've run
pip3 freeze -r requirements.txt
after getting all of the right package versions installed which is how the below file was generated.I've also specified in the readme that Python 3.11 should be used.
pyqtdarktheme
does not support Python 3.12 yet and enforcesRequires-Python <3.12,>=3.7