#6 Search Module

[hkulekci]

#6 Creating search module

• Configuration file created
• AbstractSearchService added to Search module
• AbstractIndexService and AbstractQueryService added to Search module
• Example UserIndexService and UserQueryService added
• ElasticsearchClient Service and Factory added

[hkulekci]

I create a basic implementation for Search module. I will try to create a user index and user search method. Right now, user search method create a match_all query on elasticsearch and index method, which is in AbstractIndexService class, directly indexes data to ES. We may consider adding a specific index() and search() methods for index and search services respectively.

[edigu]

Looks good to me. Can you rebase on master to resolve conflicts? I think search layer can accept/return DTO's while indexing & searching data in future. It would be nice improvement.

[edigu]

MissingArgumentException?

[hkulekci]

I tried to create concerete exceptions for some situations. For example, I used that exception on AbstractIndexService#24. Maybe we can use same exception on AbstractSearchService#56 or AbstractSearchService#87.

[edigu]

I understand. In this case id is a requirement, part of the data for a valid elastica document, validating incoming data before trying to create documents sounds good. However when searching, its a parameter (argument) which may exists or not. I think separating exceptions to three distinct classes would more appropriate :MissingArgumentException, InvalidDocumentException and InvalidArgumentException