Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep all 3rd party dependencies up-to-date #35

Merged
merged 4 commits into from
Jun 14, 2016
Merged

Conversation

edigu
Copy link
Collaborator

@edigu edigu commented Jun 14, 2016

No description provided.

@edigu edigu changed the title [WIP] Keep all 3rd party dependencies up-to-date Keep all 3rd party dependencies up-to-date Jun 14, 2016
"gedmo/doctrine-extensions": "2.4.7",
"mathiasverraes/money": "1.3.*@dev",
"gedmo/doctrine-extensions": "^2.4",
"mathiasverraes/money": "v3.0.0-beta",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be ready for production. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, old one had been dev version, already.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any major BC breaks between 1.3.x dev and 3.0 versions. IMHO using boilerplate in production is responsibility of the developer.

@hkulekci hkulekci merged commit 3f1071e into biberlabs:master Jun 14, 2016
@edigu
Copy link
Collaborator Author

edigu commented Jun 14, 2016

We need tests.

@hkulekci
Copy link
Member

hkulekci commented Jun 14, 2016

#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants