Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [ENH] implement bids-schema - part 1 #121

Closed
wants to merge 24 commits into from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Feb 4, 2021

Use the bids-schema from the specification repo to parse datasets.

Issues

  • Some suffixes are deprecated in BIDS 1.5 and not included in the schema (e.g FLASH), and therefore will be ignored by layout when parsing them.

  • FIXED - Different types of "suffixes" allow for different set of entities for the same datatype (see below T1w do have a part entity and T1map does not, even though they are both anat). Relying on the schema when parsing leads to create concatenating structures that have different set of fields.

  {
    "suffixes": [
      "T1w",
    ],
    "entities": {
      "subject": "required",
      "session": "optional",
      "run": "optional",
      "acquisition": "optional",
      "ceagent": "optional",
      "reconstruction": "optional",
      "part": "optional"
    }
  },
  {
    "suffixes": [
      "T1map",
    ],
    "entities": {
      "subject": "required",
      "session": "optional",
      "run": "optional",
      "acquisition": "optional",
      "ceagent": "optional",
      "reconstruction": "optional"
    }
  },

@Remi-Gau Remi-Gau force-pushed the remi-implement_schema branch from b977bca to a49a4b3 Compare February 4, 2021 08:39
@Remi-Gau Remi-Gau mentioned this pull request Feb 4, 2021
@Remi-Gau Remi-Gau changed the title [WIP] [ENH] implement bids-schema [WIP] [ENH] implement bids-schema - part 1 Feb 4, 2021
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Feb 4, 2021

Closing and reopening to have the dev branch as base.

@Remi-Gau Remi-Gau closed this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing or extra entities for func Add support for cbv and phase sufixes for func files
1 participant