-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regular expression jsons to be used by bids-validator and pybids #2
Comments
My current conversion code is all written in JS so dumping a node project in here feels dirty. If I ever covert it to python I'd be happy with it living in this workload, especially if this repo exposes different versions of the schemas across specification releases. |
That makes sense. Python is probably the way to go for this repo, since so few BIDS folks (myself included) know JS. Thanks for clarifying! |
FWIW, I think minting regexes for legit filenames so they could be re-used by validators etc is a great starting point. |
we already got jsonschema dump archived as
|
FWIW, taking an executive decision to make it |
FWIW, done as of 1f60004 . Check it out. |
@tsalo @rwblair should we keep this issue open? I still would not object any other useful "extract" from the schema to accompany it here but indeed unclear if we have a clear utility/purpose here since regexes on their own would have only very limited utility but could still help to decide for tools on what is "legit" part of a bids dataset. |
@rwblair has been working on using the new YAML files in the specification to build regular expressions to replace those currently in place in
bids-validator
. These regular expressions should also be useful forpybids
. One idea we briefly talked about recently would be to either move the regex-generation code frombids-validator
to here, or to push the generated regex jsons here while keeping the code in thebids-validator
repo. In either case, bothbids-validator
andpybids
could pull the jsons from this repository for their respective uses.I have a couple of questions about this:
bids-specification
(at least for now), but several automatically-derived files, like these regex jsons, would live here.The text was updated successfully, but these errors were encountered: