-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] microelectrode electrophysiology specification (BEP032) #1705
base: master
Are you sure you want to change the base?
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ec5d5e - Browse repository at this point
Copy the full SHA 7ec5d5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f393ca - Browse repository at this point
Copy the full SHA 2f393caView commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 648781a - Browse repository at this point
Copy the full SHA 648781aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3c9996 - Browse repository at this point
Copy the full SHA d3c9996View commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 08c92cd - Browse repository at this point
Copy the full SHA 08c92cdView commit details
Commits on Apr 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e2030ac - Browse repository at this point
Copy the full SHA e2030acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53f1087 - Browse repository at this point
Copy the full SHA 53f1087View commit details
Commits on Apr 18, 2024
-
Describe modality/datatype as "Microelectrode Electrophysiology"
otherwise "Electrophysiology" is too broad. Thanks @dorahermes for the note
Configuration menu - View commit details
-
Copy full SHA for fa648fe - Browse repository at this point
Copy the full SHA fa648feView commit details -
Configuration menu - View commit details
-
Copy full SHA for eef67df - Browse repository at this point
Copy the full SHA eef67dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27547f9 - Browse repository at this point
Copy the full SHA 27547f9View commit details
Commits on Apr 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6ae5e2 - Browse repository at this point
Copy the full SHA a6ae5e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a20e4b - Browse repository at this point
Copy the full SHA 9a20e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7609276 - Browse repository at this point
Copy the full SHA 7609276View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9be41f9 - Browse repository at this point
Copy the full SHA 9be41f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 983975a - Browse repository at this point
Copy the full SHA 983975aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1afdc40 - Browse repository at this point
Copy the full SHA 1afdc40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b39d64 - Browse repository at this point
Copy the full SHA 6b39d64View commit details -
Replace fancy unicode “ with simple " .
I think this is what might have freaked out `schemacode_ci / windows-latest with Python 3 (pull_request) ` (windows only!) fails with a bunch of ``` 2024-04-19T19:13:44.2815607Z self = <encodings.cp1252.IncrementalDecoder object at 0x0000028D6A14D850> 2024-04-19T19:13:44.2818292Z input = b'---\nHED:\n name: HED\n display_name: HED Tag\n description: |\n Hierarchical Event Descriptor (HED) Tag.\n ...ed or ideal position along the z axis.\n anyOf:\n - type: number\n - type: string\n enum:\n - n/a\n' 2024-04-19T19:13:44.2820386Z final = True 2024-04-19T19:13:44.2820609Z 2024-04-19T19:13:44.2820821Z def decode(self, input, final=False): 2024-04-19T19:13:44.2821664Z > return codecs.charmap_decode(input,self.errors,decoding_table)[0] 2024-04-19T19:13:44.2823260Z E UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 2105: character maps to <undefined> 2024-04-19T19:13:44.2824229Z 2024-04-19T19:13:44.2824768Z C:\hostedtoolcache\windows\Python\3.12.3\x64\Lib\encodings\cp1252.py:23: UnicodeDecodeError ```
Configuration menu - View commit details
-
Copy full SHA for f08b163 - Browse repository at this point
Copy the full SHA f08b163View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73012b3 - Browse repository at this point
Copy the full SHA 73012b3View commit details
Commits on Jun 5, 2024
-
BEP032: ephys -> microephys with {icephys, ecephys} modalities/suffix…
…es (#1806) * RF: to have "microephys" (Microelectrode physiology) for modality and icephys and ecephys for suffixes and datatypes * Reflecting decision of having two separate datatypes under the Microelectrode Electrophysiology #1800 (comment) Consensus reached during working group meeting on 2024-05-15: - modality = "Microelectrode Electrophysiology" - datatypes = "icephys" and "ecephys" - suffixes = "_icephys" and "_ecephys" * Adjust wording to Horea's recommendation * Various fixups and tune ups to wording from code review
Configuration menu - View commit details
-
Copy full SHA for a46e439 - Browse repository at this point
Copy the full SHA a46e439View commit details
Commits on Oct 16, 2024
-
Clarify wording and do mention
microephys
as shorthand for Microele……ctrode Electrophysiology
Configuration menu - View commit details
-
Copy full SHA for 05e9611 - Browse repository at this point
Copy the full SHA 05e9611View commit details
Commits on Nov 20, 2024
-
Adding markdown portion of the Bep032 (#1960)
* test * MACROS___make_suffix_table * markdown * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * undoing changes to yaml files * adding chanell * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update src/modality-specific-files/microelectrode-electrophysiology.md Co-authored-by: Yaroslav Halchenko <[email protected]> * Update src/modality-specific-files/microelectrode-electrophysiology.md Co-authored-by: Yaroslav Halchenko <[email protected]> * Update src/modality-specific-files/microelectrode-electrophysiology.md Co-authored-by: Yaroslav Halchenko <[email protected]> * Update src/modality-specific-files/microelectrode-electrophysiology.md Co-authored-by: Yaroslav Halchenko <[email protected]> * Update src/modality-specific-files/microelectrode-electrophysiology.md Co-authored-by: Yaroslav Halchenko <[email protected]> * Update src/modality-specific-files/microelectrode-electrophysiology.md Co-authored-by: Yaroslav Halchenko <[email protected]> * Update src/modality-specific-files/microelectrode-electrophysiology.md Co-authored-by: Yaroslav Halchenko <[email protected]> * adding General ephys metadata * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Examples of real datasets * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Minor tuneups to formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yaroslav Halchenko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ddeb75 - Browse repository at this point
Copy the full SHA 7ddeb75View commit details -
[ENH] Schema changes related to BEP032 (#1826)
* [FIX] Minor YAML formatting * [ENH] Added additional birthdate column for participants.tsv * [ENH] Added age_category, age_type and corresponding enums * [ENH] Added surgery_date column * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Reverted changes that better suit in a PR against master * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ENH] Added tabular_data file and columns for _probes.tsv * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ENH] Added tabular_data rules and columns for _electrodes.tsv * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ENH] Added tabular_data rules for _electrodes.tsv * [ENH] Added tabular_data rules and columns for _channels.tsv * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [FIX] Fixed pre-commit errors * [ENH] Added additional ephys columns for events.tsv * [ENH] Added tabular data rules for events.tsv to include ephys related columns * [ENH] Added metadata entities for ephys setup metadata * [ENH] Created sidecar rule file for ephys metadata and added data origin and setup fields * Made schema changes to match microephys data type * Renamed rule files from ephys to microephys * Made schema changes to match microephys data type * [ENH] Added objects and rules for coordinate system sidecar file * [ENH] Added processing microephys metadata field in rules * [ENH] Added pharmaceuticals microephys metadata field in rules * [ENH] Added supplementary microephys metadata field and rules * [ENH] Added sample microephys metadata rules * [ENH] Added task microephys metadata rules * Fixed example language convention * Added microephys in schema rule modality * Corrected SampleThickness to SliceThickness * Add yaml document separator for microephys rules file It is optional, and adding does not solve anything but makes it consistent with the other files in the folder * BF: should be a dict, not a list of dicts --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yaroslav Halchenko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2b9e757 - Browse repository at this point
Copy the full SHA 2b9e757View commit details -
Merge remote-tracking branch 'origin/master' into bep032
* origin/master: (288 commits) chore(deps): bump codecov/codecov-action from 4 to 5 (#1989) chore: Bump schema post-dev version schema-0.11.3.post3 chore(ci): Fix pytest call for make_archive chore: Remove excess test data from bidsschematools installation directories (#1985) feat(cli): Add tool for filename validation for use in pre-receive hooks (#1986) rm COC (#1979) chore: Bump schema post-dev version schema-0.11.3.post2 Update CONTRIBUTING.md (#1978) fix(schema): Check SliceTiming length against SliceEncodingDirection fix(schema): Do not warn about missing events for task-noise fix(schema): Check for existence of stim_files in beh.tsv chore: Use GITHUB_REF(_NAME) correctly chore: Debug environment chore: Bump schema post-dev version schema-0.11.3.post1 chore: Output version, set correct env var chore: Update publish_schema to publish post-releases fix(schema): Include changes to schema that do not modify spec ... Conflicts: mkdocs.yml src/schema/objects/columns.yaml src/schema/objects/metadata.yaml src/schema/objects/modalities.yaml src/schema/objects/suffixes.yaml src/schema/rules/modalities.yaml
Configuration menu - View commit details
-
Copy full SHA for 6b11f54 - Browse repository at this point
Copy the full SHA 6b11f54View commit details