Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add BEP 046- Cardiac MRI #613

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[ENH] add BEP 046- Cardiac MRI #613

wants to merge 5 commits into from
+30 −0

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 4, 2025

No description provided.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 4, 2025

@christinerogers this cannot be merged unless a link to the google doc is provided

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 4, 2025

Also this is going to require some update of the list of contributors in the spec:

045 Cardiac MRI (CMR)
NOT FOUND Edward Xu
FOUND Jefferson Casimir
FOUND Ghislain Vaillant
no email in specification/CITATION.cff.

@christinerogers
Copy link
Contributor

this follows on from #611 #612

@christinerogers christinerogers mentioned this pull request Feb 10, 2025
Merged
@effigies
Copy link
Contributor

#618 has a BEP 045 already ready to go. Should we renumber this one to 046 while we wait for it?

@christinerogers
Copy link
Contributor

christinerogers commented Feb 17, 2025 •
edited
Loading

#618 has a BEP 045 already ready to go. Should we renumber this one to 046 while we wait for it?

sure, i've renamed it to 046 everywhere, added the googledoc (now open) and invited Ghislain .

cc @Remi-Gau - ready for your review

@christinerogers christinerogers changed the title [ENH] add BEP 045 [ENH] add BEP 046 Feb 17, 2025
christinerogers and others added 3 commits February 17, 2025 13:53
@christinerogers @Remi-Gau
Update data/beps/beps.yml
c5184f7 
Co-authored-by: Remi Gau <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fcc820f 
for more information, see https://pre-commit.ci
@christinerogers
Update beps.yml
6efe2e1 
this branch should be renamed too but oh well
christinerogers
christinerogers reviewed Feb 19, 2025
View reviewed changes
@christinerogers
Update data/beps/beps.yml
7743d7a 
adding email, fixing names
@christinerogers
Copy link
Contributor

Also this is going to require some update of the list of contributors in the spec:

045 Cardiac MRI (CMR) NOT FOUND Edward Xu FOUND Jefferson Casimir FOUND Ghislain Vaillant no email in specification/CITATION.cff.

@Remi-Gau I think i've addressed all of this including an email in the beps.yml
not sure if i need to make further changes to resolve the Citation.cff issue?

@christinerogers christinerogers changed the title [ENH] add BEP 046 [ENH] add BEP 046- Cardiac MRI Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinerogers christinerogers christinerogers left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Remi-Gau @christinerogers @effigies