Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check config.xml instead of domain_dir for domain creation #504

Open
wants to merge 1 commit into
base: puppet4
Choose a base branch
from

Conversation

eloyvaldera-te
Copy link

Hi!

I some cases when de directory is already created, for example if this directory is FS mounted, puppet doesn't launch the domain creation.

To skip this situtation, we are checking config.xml file created by all domains.

@coveralls
Copy link

coveralls commented Nov 28, 2017

Coverage Status

Coverage remained the same at 2.059% when pulling 0b8416e on eloyvaldera-te:master into f39dadd on biemond:puppet4.

@biemond
Copy link
Owner

biemond commented Nov 28, 2017

Hi

I don't know if this works well, been here before, for wls the directory has to empty. we need an empty check instead

@eloyvaldera-te
Copy link
Author

You are right, for weblogic we need a empty directory.

In current version fails if directory exists when try to run wlst in next resource without descritivle errors. Using this pull request, resource will launch the domain creation if config.xml not exists, in this case wls will throws a error saying that directory is not empty.

Maybe, we can add a new resource for wls to check if directory is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants