✨ feat(pihole-unbound): Add volume and expose Unbound port

[dragonfire1119]

This commit adds a volume for the Unbound configuration and exposes the Unbound DNS port (5353/tcp and 5353/udp) in the Dockerfile. It also improves the healthcheck by reducing the interval, adding a start period, and increasing the number of retries.

The changes in the unbound_run_script file simplify the script by removing unnecessary checks and using exec to run Unbound, which allows for proper signal handling and process management.

Summary by CodeRabbit

• New Features

  • Introduced persistent storage for Unbound configuration files.
  • Exposed Unbound DNS service on TCP and UDP ports 5353.

• Improvements

  • Enhanced health check mechanism with a reduced interval and added retries for quicker issue detection.
  • Streamlined the Unbound setup script for improved efficiency and simplicity.

• Bug Fixes

  • Removed unnecessary checks in the Unbound run script, ensuring smoother execution.

[coderabbitai]

Walkthrough

The changes include modifications to the Dockerfile and a Bash script for the Pi-hole Unbound integration. The Dockerfile consolidates package installation and cleanup, introduces a volume for configuration persistence, exposes DNS service ports, and updates the health check parameters. The Bash script simplifies the setup by unconditionally creating log directories and files, and refactors the Unbound daemon startup process for improved signal handling.

Changes

File	Change Summary
pihole-unbound/Dockerfile	Consolidated package installation and cleanup, added volume for configuration, exposed ports 5353, modified health check interval and parameters.
pihole-unbound/unbound/unbound_run_script	Removed conditional checks for log directory and file creation, refactored Unbound daemon startup with exec.

Poem

🐰 In the garden of code, changes bloom bright,
With Unbound now running, all feels just right.
Ports open wide, configurations stay,
A cleaner script hops in, leading the way.
Oh, celebrate progress, let’s dance and cheer,
For a faster DNS, the future is near! 🌼✨

Tip

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 60b0ba7 and 7d8c0c8.

Files selected for processing (2)

• pihole-unbound/Dockerfile (2 hunks)
• pihole-unbound/unbound/unbound_run_script (3 hunks)

Additional comments not posted (7)

pihole-unbound/unbound/unbound_run_script (3)

18-18: LGTM!

The change simplifies the script by unconditionally creating the log directory using mkdir -p, which is a good practice.

---

21-21: LGTM!

The change simplifies the script by unconditionally creating the log file using touch, which is a good practice.

---

42-42: LGTM!

The change refactors the script to start the Unbound daemon using exec, which is a good practice for better signal handling and process management.

pihole-unbound/Dockerfile (4)

7-11: LGTM!

The change consolidates the package installation and cleanup into a single RUN command, which helps to reduce the image size. The use of --no-install-recommends flag further reduces the image size by avoiding the installation of unnecessary packages.

---

37-38: LGTM!

The addition of a volume for the Unbound configuration directory is a great improvement. It allows for persistent storage of configuration files across container restarts, ensuring that any changes made to the configuration are maintained.

---

40-41: LGTM!

Exposing the Unbound DNS service on both TCP and UDP ports 5353 is crucial for proper DNS resolution functionality. It allows the Unbound service to be accessed externally and ensures compatibility with different DNS query types and client configurations.

---

47-49: LGTM!

The modifications to the health check parameters are a great improvement:

• Reducing the interval from 1 minute to 30 seconds ensures that any issues with the DNS service are detected more quickly.
• Adding a start period of 30 seconds allows the service to initialize properly before health checks begin.
• Increasing the number of retries to 3 enhances the reliability of the health monitoring process.

These changes collectively improve the responsiveness and reliability of the health check mechanism.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.